fix(auth): register vertex in PROVIDER_REGISTRY for auxiliary clients - #61933
Open
Bartok9 wants to merge 2 commits into
Open
fix(auth): register vertex in PROVIDER_REGISTRY for auxiliary clients#61933Bartok9 wants to merge 2 commits into
Bartok9 wants to merge 2 commits into
Conversation
Bartok9
force-pushed
the
fix/61852-vertex-provider-registry
branch
from
July 10, 2026 07:29
d1807d1 to
7f861f0
Compare
teknium1
reviewed
Jul 10, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for tracing this to the registry boundary. Current main confirms the premise: hermes_cli/auth.py:455 excludes Vertex from auto-promotion, while agent/auxiliary_client.py:4858 returns (None, None) before the existing Vertex branch at agent/auxiliary_client.py:5012 can run.
Problems
tests/agent/test_vertex_provider_registry.py:12importspytest, but the new test module does not use it.
Suggested changes
- Remove the unused
pytestimport.
Automated hermes-sweeper review.
| """ | ||
|
|
||
| from unittest.mock import MagicMock, patch | ||
|
|
Contributor
There was a problem hiding this comment.
pytest is not used in this module; remove this import.
Bartok9
force-pushed
the
fix/61852-vertex-provider-registry
branch
from
July 10, 2026 17:17
7f861f0 to
a4eb53f
Compare
Contributor
Author
|
Thanks for the review! Removed the unused |
Bartok9
force-pushed
the
fix/61852-vertex-provider-registry
branch
from
July 10, 2026 23:06
a4eb53f to
21db6aa
Compare
14 tasks
Rebuilt on latest main (Bartok9 hygiene 2026-08-01). Original: NousResearch#61933
Contributor
Author
|
Rebuilt onto latest — Bartok9 public PR hygiene 2026-08-01 |
Bartok9
force-pushed
the
fix/61852-vertex-provider-registry
branch
from
August 1, 2026 17:37
21db6aa to
7259c32
Compare
…tok9 Per-PR attribution so check-attribution passes on this branch (Teknium).
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Closes #61852.
Main chat already worked: resolve_runtime_provider special-cases Vertex OAuth/ADC. Auxiliary work goes through resolve_provider_client, which looks up PROVIDER_REGISTRY. Plugin auto-promotion only admits auth_type=api_key providers, so vertex was missing and the resolver returned (None, None) — silent failure on every aux task when no aggregator fallback keys exist.
The fix mirrors Bedrock static aws_sdk registration so the existing auth_type == vertex branch in auxiliary_client can run.
Verification