Skip to content

fix(auth): register vertex in PROVIDER_REGISTRY for auxiliary clients - #61933

Open
Bartok9 wants to merge 2 commits into
NousResearch:mainfrom
Bartok9:fix/61852-vertex-provider-registry
Open

fix(auth): register vertex in PROVIDER_REGISTRY for auxiliary clients#61933
Bartok9 wants to merge 2 commits into
NousResearch:mainfrom
Bartok9:fix/61852-vertex-provider-registry

Conversation

@Bartok9

@Bartok9 Bartok9 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a static ProviderConfig for vertex (auth_type=vertex) to PROVIDER_REGISTRY.
  • Restores auxiliary-task LLM clients (title generation, compression, vision, session search, curator) on Vertex-only deployments.

Motivation

Closes #61852.

Main chat already worked: resolve_runtime_provider special-cases Vertex OAuth/ADC. Auxiliary work goes through resolve_provider_client, which looks up PROVIDER_REGISTRY. Plugin auto-promotion only admits auth_type=api_key providers, so vertex was missing and the resolver returned (None, None) — silent failure on every aux task when no aggregator fallback keys exist.

The fix mirrors Bedrock static aws_sdk registration so the existing auth_type == vertex branch in auxiliary_client can run.

Verification

  • python3 -m pytest tests/agent/test_vertex_provider_registry.py -q — 5 passed
  • Did NOT change: runtime_provider vertex path, vertex_adapter token minting, or api-key plugin auto-promotion rules

@Bartok9
Bartok9 force-pushed the fix/61852-vertex-provider-registry branch from d1807d1 to 7f861f0 Compare July 10, 2026 07:29
@alt-glitch alt-glitch added type/bug Something isn't working comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint comp/cli CLI entry point, hermes_cli/, setup wizard area/auth Authentication, OAuth, credential pools provider/gemini Google Gemini (AI Studio, Cloud Code) P2 Medium — degraded but workaround exists labels Jul 10, 2026

@teknium1 teknium1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracing this to the registry boundary. Current main confirms the premise: hermes_cli/auth.py:455 excludes Vertex from auto-promotion, while agent/auxiliary_client.py:4858 returns (None, None) before the existing Vertex branch at agent/auxiliary_client.py:5012 can run.

Problems

  • tests/agent/test_vertex_provider_registry.py:12 imports pytest, but the new test module does not use it.

Suggested changes

  • Remove the unused pytest import.

Automated hermes-sweeper review.

"""

from unittest.mock import MagicMock, patch

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytest is not used in this module; remove this import.

@Bartok9
Bartok9 force-pushed the fix/61852-vertex-provider-registry branch from 7f861f0 to a4eb53f Compare July 10, 2026 17:17
@Bartok9

Bartok9 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the review! Removed the unused pytest import from tests/agent/test_vertex_provider_registry.py (the module uses unittest.mock only). Pushed as a4eb53fdd5. Local run: 6 passed.

@Bartok9
Bartok9 force-pushed the fix/61852-vertex-provider-registry branch from a4eb53f to 21db6aa Compare July 10, 2026 23:06
@teknium1 teknium1 added sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:risk-security-boundary Sweeper risk: may affect sandboxing, auth, credentials, or sensitive data sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users labels Jul 11, 2026
Rebuilt on latest main (Bartok9 hygiene 2026-08-01).
Original: NousResearch#61933
@Bartok9

Bartok9 commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Rebuilt onto latest main via patch re-apply (force-push). Please re-run CI.

— Bartok9 public PR hygiene 2026-08-01

@Bartok9
Bartok9 force-pushed the fix/61852-vertex-provider-registry branch from 21db6aa to 7259c32 Compare August 1, 2026 17:37
…tok9

Per-PR attribution so check-attribution passes on this branch (Teknium).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/auth Authentication, OAuth, credential pools comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists provider/gemini Google Gemini (AI Studio, Cloud Code) sweeper:blast-contained Sweeper blast radius: contained — one narrow path / opt-in / few users sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:risk-security-boundary Sweeper risk: may affect sandboxing, auth, credentials, or sensitive data type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Every auxiliary task silently fails on provider: vertex

3 participants