fix(wheel): include hermes_cli subpackages in wheel build - #34505
Closed
arshkumarsingh wants to merge 1 commit into
Closed
fix(wheel): include hermes_cli subpackages in wheel build#34505arshkumarsingh wants to merge 1 commit into
arshkumarsingh wants to merge 1 commit into
Conversation
dashboard_auth and proxy subpackages were excluded from the v0.15.1 wheel because `hermes_cli.*` was missing from `[tool.setuptools.packages.find].include` while every other package had its `.*` glob. This caused the dashboard to crash with ModuleNotFoundError when the wheel was installed. Fixes NousResearch#34346
Collaborator
Author
|
Duplicate of #27728 which is the comprehensive fix (adds hermes_cli., acp_adapter., MANIFEST.in grafts, Homebrew formula, and invariant tests). Closing in favor of that. |
This was referenced May 29, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
"hermes_cli.*"to[tool.setuptools.packages.find].includeto fix the v0.15.1 wheel missingdashboard_auth/andproxy/subpackages.Root Cause
[tool.setuptools.packages.find].includelisted"hermes_cli"but was missing"hermes_cli.*". Every other package in the list (agent.*,tools.*,gateway.*,tui_gateway.*,plugins.*,providers.*) had its subpackage glob — onlyhermes_cliwas missing it. This causedhermes_cli/dashboard_auth/andhermes_cli/proxy/to be excluded from the built wheel.Impact
The dashboard subprocess crashes with:
Only affects wheel installs (e.g.
uv pip install hermes-agentfrom 0.14.x). The Docker:latestimage uses an editable install so it bypasses the bug.Changes
One line in
pyproject.toml: added"hermes_cli.*"to the include list.Verification
Built wheel with
uv build --wheeland confirmed the RECORD now contains:(Alongside the existing
plugins/dashboard_auth/nous/plugin directory — these are separate things.)Fixes #34346