fix(packaging): include hermes_cli subpackages in wheel build - #34717
Closed
beardthelion wants to merge 1 commit into
Closed
fix(packaging): include hermes_cli subpackages in wheel build#34717beardthelion wants to merge 1 commit into
beardthelion wants to merge 1 commit into
Conversation
pyproject.toml packages.find.include listed hermes_cli but not hermes_cli.*, so subpackages (dashboard_auth, proxy, proxy.adapters) were silently excluded from built wheels. Anyone installing via pip, Homebrew, or Docker got ModuleNotFoundError at runtime. Fixes NousResearch#34701, Fixes NousResearch#27664
alt-glitch
added
type/bug
Collaborator
Contributor
Author
|
Closing — duplicate of #27728. Apologies for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
pyproject.tomlpackages.find.includelistedhermes_clibut nothermes_cli.*. Subpackages (dashboard_auth,proxy,proxy.adapters) were silently excluded from built wheels. Local dev worked fine (source tree imports) but anyone installing via pip, Homebrew, or Docker gotModuleNotFoundErrorat runtime.Related Issue
Fixes #34701, Fixes #27664
Type of Change
Changes Made
pyproject.toml: Added"hermes_cli.*"to[tool.setuptools.packages.find]include listHow to Test
python -c "from setuptools import find_packages; pkgs = find_packages(include=['hermes_cli', 'hermes_cli.*']); print([p for p in pkgs if p.startswith('hermes_cli')])"hermes_cli.dashboard_auth,hermes_cli.proxy,hermes_cli.proxy.adaptersappearpython -m build --wheeland verify subpackages are includedChecklist