fix(packaging): add hermes_cli.* to setuptools include so proxy subpa… - #28060
fix(packaging): add hermes_cli.* to setuptools include so proxy subpa…#28060LifeJiggy wants to merge 2 commits into
Conversation
…ckage ships in wheel hermes_cli/proxy/ and hermes_cli/proxy/adapters/ exist in git but were excluded from the wheel because the setuptools find config only included 'hermes_cli' (top-level) without 'hermes_cli.*' (recursive subpackages). Every other top-level package already had its .* counterpart. Fixes NousResearch#27938.
austinpickett
left a comment
There was a problem hiding this comment.
Please use PULL_REQUEST_TEMPLATE.md
There was a problem hiding this comment.
Pull request overview
This PR updates the Python packaging configuration so hermes_cli subpackages, including hermes_cli.proxy, are included in built wheels.
Changes:
- Adds
hermes_cli.*to setuptools package discovery. - Addresses the missing proxy subpackage reported in issue #27938.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| [tool.setuptools.packages.find] | ||
| include = ["agent", "agent.*", "tools", "tools.*", "hermes_cli", "gateway", "gateway.*", "tui_gateway", "tui_gateway.*", "cron", "acp_adapter", "plugins", "plugins.*", "providers", "providers.*"] | ||
| include = ["agent", "agent.*", "tools", "tools.*", "hermes_cli", "hermes_cli.*", "gateway", "gateway.*", "tui_gateway", "tui_gateway.*", "cron", "acp_adapter", "plugins", "plugins.*", "providers", "providers.*"] |
|
|
||
| [tool.setuptools.packages.find] | ||
| include = ["agent", "agent.*", "tools", "tools.*", "hermes_cli", "gateway", "gateway.*", "tui_gateway", "tui_gateway.*", "cron", "acp_adapter", "plugins", "plugins.*", "providers", "providers.*"] | ||
| include = ["agent", "agent.*", "tools", "tools.*", "hermes_cli", "hermes_cli.*", "gateway", "gateway.*", "tui_gateway", "tui_gateway.*", "cron", "acp_adapter", "plugins", "plugins.*", "providers", "providers.*"] |
|
BoardJames triage: |
fix/proxy-wheel-missing → fixes #27938
fix(packaging): add hermes_cli.* to setuptools include so proxy subpackage ships in wheel
After compression, last_prompt_tokens was set to estimate_request_tokens_rough() which overcounts by 30-50% for tool-heavy sessions (tool schemas counted twice). This inflated value caused should_compress() to return True on the very next turn, triggering compression every 1-2 turns in a never-ending loop.
Setting to 0 forces the preflight to recalculate from the actual compressed messages on the next turn, which produces a value well below threshold_tokens. Real API response usage data overwrites last_prompt_tokens via update_from_response() on the next API call. Fixes #27938.
Related Issue
Fixes #27938
Type of Change
Changes Made
How to Test