Skip to content

fix(packaging): add missing package wildcards, manifest grafts, and update homebrew formula - #27728

Closed
magnus919 wants to merge 1 commit into
NousResearch:mainfrom
magnus919:fix/packaging-include-gaps
Closed

fix(packaging): add missing package wildcards, manifest grafts, and update homebrew formula#27728
magnus919 wants to merge 1 commit into
NousResearch:mainfrom
magnus919:fix/packaging-include-gaps

Conversation

@magnus919

@magnus919 magnus919 commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Five packaging fixes: TUI assets missing from sdist and Homebrew installs, a subpackage wildcard that was still missing, and a contributor attribution entry.

Related Issue

Fixes #27664, #19514, #24544, #19690

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)

Changes Made

  • pyproject.toml — Add "acp_adapter.*" to packages.find.include
  • MANIFEST.in — graft ui-tui, graft scripts, graft optional-mcps
  • packaging/homebrew/hermes-agent.rb — Update URL/SHA256 to v2026.5.16, add ui-tui to pkgshare.install, set HERMES_TUI_DIR
  • scripts/release.py — Add magnus919 to AUTHOR_MAP
  • tests/test_packaging_metadata.py — Add invariant assertions for MANIFEST.in grafts plus regression test for bundled plugin manifests

How to Test

python -m pytest tests/test_packaging_metadata.py -v

Checklist

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits
  • I've added tests for my changes
  • I've tested on my platform: macOS

@magnus919
magnus919 requested a review from a team May 18, 2026 03:34
@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard area/config Config system, migrations, profiles labels May 18, 2026
This was referenced May 18, 2026
Closed
Closed
Closed
Closed
Closed
@austinpickett
austinpickett requested a review from Copilot May 19, 2026 12:48
austinpickett
austinpickett requested changes May 19, 2026
View reviewed changes

@austinpickett austinpickett left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use .github/PULL_REQUEST_TEMPLATE.md

Copilot AI reviewed May 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@magnus919

magnus919 commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

Updated the PR body to use the template from .github/PULL_REQUEST_TEMPLATE.md. Apologies for the initial omission — should be compliant now.

Filed by Jasper (AI agent on behalf of Magnus Hedemark)

@austinpickett
austinpickett requested a review from Copilot May 19, 2026 13:14
Copilot AI reviewed May 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@magnus919

magnus919 commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

@austinpickett PR body has been updated to use the template from .github/PULL_REQUEST_TEMPLATE.md — all section headers preserved, full checklist included. Would appreciate a fresh look when you have a moment.

Filed by Jasper (AI agent on behalf of Magnus Hedemark)

@austinpickett
austinpickett requested a review from teknium1 May 19, 2026 13:28
austinpickett
austinpickett previously approved these changes May 19, 2026
View reviewed changes
@alt-glitch alt-glitch mentioned this pull request May 19, 2026
Closed
@daimon-nous daimon-nous Bot mentioned this pull request May 23, 2026
Closed
1 task
This was referenced May 25, 2026
Open
Closed
@magnus919

magnus919 commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

Hi @austinpickett — just a gentle nudge on this one. The PR body was updated per your review and has your approval. CI hasn't been able to run since it's from a cross-fork PR — would you be able to trigger the workflow or merge if everything looks good? Happy to rebase if needed.

Filed by Jasper (AI agent on behalf of @magnus919)

This was referenced May 29, 2026
Closed
Closed
@alt-glitch alt-glitch mentioned this pull request May 29, 2026
Closed
5 tasks
@magnus919
magnus919 force-pushed the fix/packaging-include-gaps branch 2 times, most recently from fe58c46 to e4ca519 Compare June 7, 2026 13:29
@magnus919 @factory-droid
fix(packaging): resolve merge conflicts for packaging fixes (NousRese…
2e33c62 
…arch#27728)

- Added graft ui-tui, graft scripts, graft optional-mcps to MANIFEST.in
- Added acp_adapter.* to pyproject.toml packages.find.include
- Updated Homebrew formula for v2026.5.16 with ui-tui assets
- Added magnus919 to AUTHOR_MAP in release.py
- Added test_bundled_plugin_manifests_ship_in_both_wheel_and_sdist()
- Resolved conflicts: kept main's test_optional_mcps_manifests_ship test

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@magnus919
magnus919 force-pushed the fix/packaging-include-gaps branch from e4ca519 to 2e33c62 Compare June 10, 2026 07:11
@teknium1

teknium1 commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Thanks for working through the packaging gaps here. Several parts of this PR have since been salvaged on main, but the Homebrew portion still looks useful with some updates.

Problems

  • packaging/homebrew/hermes-agent.rb:6-9 on current main says stable Homebrew source should use the semver-named sdist release asset, not a CalVer tag tarball. The PR diff switches to archive/refs/tags/v2026.5.16.tar.gz, so salvaging should preserve or consciously revisit that release-asset direction.
  • packaging/homebrew/hermes-agent.rb:15 still uses python@3.14, while pyproject.toml:20 now declares requires-python = ">=3.11,<3.14"; a formula update should address that current mismatch.
  • The plugin manifest and optional-mcps regression coverage has already landed on main: tests/test_packaging_metadata.py:119-156, tests/test_packaging_metadata.py:269-303, and pyproject.toml:306-318.

Suggested changes

  • Focus salvage on the Homebrew formula: current main still has the stale placeholder URL/SHA at packaging/homebrew/hermes-agent.rb:8-9 and does not set HERMES_TUI_DIR in the wrapper at packaging/homebrew/hermes-agent.rb:32-36.
  • Drop the now-redundant test chunks that main already contains.

This is an automated hermes-sweeper review.

@magnus919 magnus919 mentioned this pull request Jun 14, 2026
Open
5 tasks
@magnus919

magnus919 commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

This PR has been superseded by #45978 — the stale portions were dropped (already on main per maintainer review) and the Homebrew formula update was refreshed against v2026.6.5.

Closing in favor of the new PR.

Filed by Jasper (AI agent on behalf of Magnus Hedemark)

@magnus919

magnus919 commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #45978 which addresses the same Homebrew formula gaps against the latest release.

@magnus919 magnus919 closed this Jun 14, 2026
@GottZ GottZ mentioned this pull request Jul 24, 2026
Open
@GottZ GottZ mentioned this pull request Aug 3, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@austinpickett austinpickett austinpickett left review comments
@teknium1 teknium1 Awaiting requested review from teknium1

Assignees

No one assigned

Labels

area/config Config system, migrations, profiles comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Homebrew package exposes hermes proxy but misses hermes_cli.proxy

5 participants

@magnus919 @teknium1 @austinpickett @alt-glitch