fix(packaging): include hermes_cli subpackages in wheel (#27938) - #28231
Closed
nevasini1 wants to merge 1 commit into
Closed
fix(packaging): include hermes_cli subpackages in wheel (#27938)#28231nevasini1 wants to merge 1 commit into
nevasini1 wants to merge 1 commit into
Conversation
…#27938) The `[tool.setuptools.packages.find].include` list in pyproject.toml listed `hermes_cli` but not `hermes_cli.*`, so any subpackage of `hermes_cli/` was excluded from the built wheel. PR NousResearch#25969 added `hermes_cli/proxy/` and `hermes_cli/proxy/adapters/` without updating the include list, which is how this surfaced: `hermes proxy <subcmd>` fails on a pip-installed v0.14.0 with `ModuleNotFoundError: No module named 'hermes_cli.proxy'`. Adding `hermes_cli.*` to the include list matches the existing pattern already used for `agent.*`, `tools.*`, `gateway.*`, `tui_gateway.*`, `plugins.*`, and `providers.*`, and makes future hermes_cli subpackages ship by default. Verified by `python -m build --wheel` against this commit: the wheel now contains `hermes_cli/proxy/{__init__,cli,server}.py` and `hermes_cli/proxy/adapters/{__init__,base,nous_portal}.py`, all of which were absent from the v0.14.0 wheel. Fixes NousResearch#27938.
Collaborator
Author
|
Thanks for the pointer — closing as duplicate of #27728, which lands the same For the record on how this dupe happened: I searched open PRs with |
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #27938 — the v0.14.0 wheel is missing
hermes_cli/proxy/(and itsadapters/subpackage), so allhermes proxy <subcmd>invocations fail withModuleNotFoundError: No module named 'hermes_cli.proxy'on pip-installed installs.Root cause
pyproject.tomlconfigures the wheel contents via setuptools'packages.findinclude list:The list includes
hermes_cli(the top-level package) but nothermes_cli.*. Every other multi-level package in the project is declared with both forms —agent+agent.*,tools+tools.*,gateway+gateway.*,tui_gateway+tui_gateway.*,plugins+plugins.*,providers+providers.*.hermes_cliwas the only outlier, which was harmless until PR #25969 (commitccb5aae0d) addedhermes_cli/proxy/andhermes_cli/proxy/adapters/.Fix
Add
hermes_cli.*to the include list. One line; matches the convention already used by every other package in the same list.Verification
Built a wheel from this commit with
python -m build --wheeland inspected the contents:All seven files from the issue's
git ls-tree -r v2026.5.16 -- hermes_cli/proxylisting are now in the wheel.Test plan
python -m build --wheelproduces a wheel that containshermes_cli/proxy/andhermes_cli/proxy/adapters/.hermes proxy providerslistsnous — Nous Portalinstead of raisingModuleNotFoundError(the reporter's verification step in v0.14.0: hermes_cli.proxy missing from wheel — ModuleNotFoundError onhermes proxy <subcommand>#27938 — confirmed mechanically via wheel contents; please re-run on CI install).🤖 Generated with Claude Code