pythonPackages.scs: init at 2.1.1

[drewrisinger]

Motivation for this change

Add dependency for qiskit (cvxpy's dependency).
Python interface for C Splitting Cone Solver. C Package in tree at lib.science.math.scs.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[drewrisinger]

@GrahamcOfBorg build python3Packages.scs

[drewrisinger]

I had originally done that but wasn't sure what the best/most replicable way of moving the C source to source/scs was. I will look at the quoted example.

…

On Thu, Jan 30, 2020, 7:56 PM Benjamin Hipple ***@***.***> wrote: ***@***.**** requested changes on this pull request. ------------------------------ In pkgs/development/python-modules/scs/default.nix <#78897 (comment)>: > + # check inputs +, nose +}: + +buildPythonPackage rec { + pname = "scs"; + version = "2.1.1"; + + disabled = pythonOlder "3.5"; + + src = fetchFromGitHub { + owner = "bodono"; + repo = "scs-python"; + rev = "f02abdc0e2e0a5851464e30f6766ccdbb19d73f0"; # need to choose commit manually, untagged + sha256 = "01ghvyylxql7jvdcwy65wf7y5qykqyqkbysy402zfhgmm9dxizgv"; + fetchSubmodules = true; Ihttps://github.com/bodono/scs-python/blob/master/setup.py If you look at what the upstream src repo and setup.py are doing, it appears they're shipping the scs C library as a git submodule, then having python recompile it from scratch. In the nix distro, we generally prefer to have the C package stand-alone, then have the python package just link the package as a proper distribution dependency without vendoring. An example of a package that does this is pyarrow: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/pyarrow/default.nix — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#78897?email_source=notifications&email_token=ACNZYI3UY24VSDUTC4WZ2A3RANZKLA5CNFSM4KN26G32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCTXX7SY#pullrequestreview-351240139>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACNZYI5HCGHDBXIUM4UDW6DRANZKLANCNFSM4KN26G3Q> .

[drewrisinger]

@GrahamcOfBorg eval

[drewrisinger]

@bhipple suggested changes made. Please review/approve.

[jonringer]

@GrahamcOfBorg build pythonPackages.scs
@GrahamcOfBorg build python3Packages.scs
@GrahamcOfBorg build python38Packages.scs

[bhipple]

Looks much nicer now! Thanks for the help with best practices too, @jonringer.