Skip to content

pythonPackages.cvxpy: init at 1.0.25 (and its dependencies)#80342

Closed
arnoldfarkas wants to merge 5 commits intoNixOS:masterfrom
WorldQuant:wq_cvxpy
Closed

pythonPackages.cvxpy: init at 1.0.25 (and its dependencies)#80342
arnoldfarkas wants to merge 5 commits intoNixOS:masterfrom
WorldQuant:wq_cvxpy

Conversation

@arnoldfarkas
Copy link
Copy Markdown
Contributor

@arnoldfarkas arnoldfarkas commented Feb 17, 2020

Motivation for this change

Packaging Python module 'cvxpy' 1.0.25 in Nix, and its missing dependencies: 'ecos-python' 2.0.7.post1, 'osqp-python' 0.6.1 and 'scs-python' 2.1.1-2.
Please note that test case ipc_closed_handle in libuv times out, disabling that test is submitted as a separate PR as well: #80341.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package labels Feb 17, 2020
@ofborg ofborg bot requested review from cstrahan and dotlambda February 17, 2020 09:35
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Feb 17, 2020
@drewrisinger
Copy link
Copy Markdown
Contributor

drewrisinger commented Feb 20, 2020

Possible duplicate of #78898 ?
Most of the sub-dependencies have been moved in-tree at this point.

@jonringer
Copy link
Copy Markdown
Contributor

jonringer commented Feb 22, 2020

superseded by #78898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@cstrahan cstrahan Awaiting requested review from cstrahan

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arnoldfarkas @drewrisinger @jonringer