pythonPackages.qiskit-terra: init at 0.12.0#80464
Merged
jonringer merged 1 commit intoNixOS:masterfrom Feb 25, 2020
Merged
Conversation
ofborg
bot
added
6.topic: python
drewrisinger
force-pushed
the
dr-pr-python-qiskit-terra
branch
from
0144593 to
29269ec
Compare
10 tasks
drewrisinger
force-pushed
the
dr-pr-python-qiskit-terra
branch
from
29269ec to
07ee8d1
Compare
Contributor
Author
|
@GrahamcOfBorg build python37Packages.qiskit-terra python38Packages.qiskit-terra |
drewrisinger
force-pushed
the
dr-pr-python-qiskit-terra
branch
from
07ee8d1 to
d1b9cbf
Compare
Contributor
Author
|
@GrahamcOfBorg build python37Packages.qiskit-terra python38Packages.qiskit-terra |
10 tasks
drewrisinger
force-pushed
the
dr-pr-python-qiskit-terra
branch
from
d1b9cbf to
ea81c30
Compare
Contributor
Author
|
@GrahamcOfBorg build python37Packages.qiskit-terra python38Packages.qiskit-terra |
jonringer
reviewed
Feb 22, 2020
jonringer
approved these changes
Feb 22, 2020
Contributor
jonringer
left a comment
jonringer
left a comment
There was a problem hiding this comment.
I guess the tests aren't too damaging to the huge size of the closure already:
[nix-shell:/home/jon/.cache/nixpkgs-review/pr-80464-1]$ nix path-info -Sh ./results/python37Packages.qiskit-terra
/nix/store/rrwx7l0gq49cc9zb3y49zkx8vy7j4y5m-python3.7-qiskit-terra-0.12.0 388.2M
[nix-shell:/home/jon/.cache/nixpkgs-review/pr-80464-1]$ du -hd0 ./results/python37Packages.qiskit-terra/lib/python3.7/site-packages/test/
4.5M ./results/python37Packages.qiskit-terra/lib/python3.7/site-packages/test/
[nix-shell:/home/jon/.cache/nixpkgs-review/pr-80464-1]$ du -hd0 ./results/python37Packages.qiskit-terra/lib/python3.7/site-packages/examples/
96K ./results/python37Packages.qiskit-terra/lib/python3.7/site-packages/examples/
Contributor
|
@GrahamcOfBorg build python37Packages.qiskit-terra python38Packages.qiskit-terra |
Qiskit is a quantum information toolkit from IBM. This commit follows the new Qiskit scheme of breaking from one large package into smaller packages (terra, aer, etc), and then having a single meta-package "qiskit" that comprises them.
drewrisinger
force-pushed
the
dr-pr-python-qiskit-terra
branch
from
ea81c30 to
d3cdcb6
Compare
Contributor
Author
|
@GrahamcOfBorg build python37Packages.qiskit-terra python38Packages.qiskit-terra |
jonringer
approved these changes
Feb 25, 2020
Contributor
jonringer
left a comment
jonringer
left a comment
There was a problem hiding this comment.
diff LGTM
commit LGTM
[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80464
2 package built:
python37Packages.qiskit-terra python38Packages.qiskit-terra
Contributor
|
@GrahamcOfBorg build python37Packages.qiskit-terra python38Packages.qiskit-terra |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update qiskit according to new upstream package structure (collection of subpackages). This is broken out of #78772. Would like to get it into 20.03 if at all possible. Has one out-of-tree dependency: pythonPackages.pylatexenc (#78878). Will rebase & remove that commit when #78878 is approved.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)