python3.pkgs.setuptools-rust: Revert "adjust setupHook inclusion condition"

[doronbehar]

Reverts #480005

[doronbehar]

@trofi please see this PR in conjunction with:

• python3: let lib.makeScopeWithSplicing' do its job #482863

Regarding your comment here:

• python3Packages.setuptools-rust: fix python version inconsistency #473299 (comment)

[doronbehar]

I'd really like to get this into the current staging-next cycle - cc @vcunat .

[vcunat]

The rebuild amount seems OK if it gets merged within a day or two, I'd say. But I don't have capacity to really review the change.

[doronbehar]

The rebuild amount seems OK if it gets merged within a day or two, I'd say. But I don't have capacity to really review the change.

I've requested for a review from @trofi, @natsukium , @Aleksanaa , @ElvishJerricco , @DavHau , @adisbladis and @alois31, and only @alois31 reviewed #482863 . Anyway they've had ~2 weeks to reply, and I'm willing to take responsibility for any potential breakage. So I'm merging.

[lheckemann]

I'm not sure if this is #476822 or not, but 6421482 from this PR seems to worsen the interaction between overrides and splicing:

[linus@🌲:~/nixpkgs/master]$ nix-instantiate --eval -E 'with import ./. {}; (python313.override { enableOptimizations = true; }).pythonOnBuildForHost.outPath'
"/nix/store/m1fw8l8y9ycxh5dzispbb7cwl6rra14l-python3-3.13.12"

[linus@🌲:~/nixpkgs/master]$ nix-instantiate --eval -E 'with import ./. {}; (python313.override { enableOptimizations = true; }).outPath'
"/nix/store/ll6yd15y7cg5p6wb3pz7dzpz24c5knws-python3-3.13.12"

[linus@🌲:~/nixpkgs/master]$ nix-instantiate --eval -E 'with import ./. {}; python313.outPath'
"/nix/store/m1fw8l8y9ycxh5dzispbb7cwl6rra14l-python3-3.13.12"

[linus@🌲:~/nixpkgs/master]$ git revert 64214826833482bb3b4fd89b77aabf1248abe33b
Auto-merging pkgs/development/interpreters/python/cpython/default.nix
[detached HEAD 98649e80f5af] Revert "python3: let lib.mkScopeWithSplicing do its job"
 1 file changed, 9 insertions(+), 3 deletions(-)

[linus@🌲:~/nixpkgs/master]$ nix-instantiate --eval -E 'with import ./. {}; (python313.override { enableOptimizations = true; }).pythonOnBuildForHost.outPath'
"/nix/store/ll6yd15y7cg5p6wb3pz7dzpz24c5knws-python3-3.13.12"

[linus@🌲:~/nixpkgs/master]$ nix-instantiate --eval -E 'with import ./. {}; (python313.override { enableOptimizations = true; }).outPath'
"/nix/store/ll6yd15y7cg5p6wb3pz7dzpz24c5knws-python3-3.13.12"

In the absence of cross, I'd expect pythonOnBuildForHost to be the same as the regular python, but here it ends up being the non-overridden one again. This breaks pyproject-nix's venvs when using an overridden python, since the shebangs are different from the expected ones, and don't get fixed.

cc @adisbladis

[doronbehar]

Here's a proposed fix:

• python3: propagate overrides of spliced pythons #498251

Indeed that inputs' line wasn't completely useless.

[adisbladis]

@lheckemann I've implemented a workaround in pyproject-nix/pyproject.nix#420. Could you test this and see if it fixes the problem for you?