python3Packages.setuptools-rust: fix python version inconsistency#473299
Merged
Aleksanaa merged 2 commits intoNixOS:staging-nextfrom Dec 23, 2025
Merged
python3Packages.setuptools-rust: fix python version inconsistency#473299Aleksanaa merged 2 commits intoNixOS:staging-nextfrom
Aleksanaa merged 2 commits intoNixOS:staging-nextfrom
Conversation
mweinelt
approved these changes
Dec 22, 2025
Member
Author
Should not break cross |
Member
Author
|
|
Member
Author
|
@ofborg build python312Packages.bcrypt python313Packages.bcrypt python314Packages.bcrypt |
Merged
via the queue into
NixOS:staging-next
with commit Dec 23, 2025
a48f11c
36 of 42 checks passed
Contributor
|
Bisect says that the change caused the eval failure for |
Member
Author
|
It's |
Member
Author
|
Okay I know, for some reasons, |
Member
Author
|
This is because |
Aleksanaa
commented
Dec 25, 2025
| # targetPackages.python3 is not always available, for example when including | ||
| # setuptools-rust via buildInputs instead of nativeBuildInputs or building it directly. | ||
| setupHook = | ||
| if !(targetPackages ? python3) then |
Member
Author
There was a problem hiding this comment.
The previous workaround is still needed, I'll add it back
13 tasks
Merged
13 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #467817 (comment)
staging-next: #471587
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.