python3: let lib.makeScopeWithSplicing' do its job#482863
Closed
doronbehar wants to merge 1 commit intoNixOS:masterfrom
Closed
python3: let lib.makeScopeWithSplicing' do its job#482863doronbehar wants to merge 1 commit intoNixOS:masterfrom
lib.makeScopeWithSplicing' do its job#482863doronbehar wants to merge 1 commit intoNixOS:masterfrom
Conversation
Fixes NixOS#476822 and NixOS#480467 . If merged, NixOS#480005 should be reverted (on branch `staging`). Co-Authored-By: Colin <colin@uninsane.org>
13 tasks
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
uninsane
changed the title
lib.makeScopeWithSplicing' do its job
alois31
reviewed
Jan 25, 2026
Contributor
alois31
left a comment
alois31
left a comment
There was a problem hiding this comment.
I can confirm it fixes the issue. However I am not familiar with the Python splicing to judge what the effects of removing the inputs' overriding entirely are, so someone else should look at that.
3 tasks
Contributor
Author
|
Since this is not urgent, and it is easier to see the justification of this in conjunction with #482866 , which should be merged a bit urgently (to the on-going staging-next cycle), I'm closing this PR and will cherry-pick the commit here to #482866 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.