python3.pkgs.setuptools-rust: adjust setupHook inclusion condition

[doronbehar]

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[doronbehar]

BTW I'm surprised there are no rebuilds triggered. There are many packages that use setupttols-rust in their build-system...

[doronbehar]

Aish I see this change breaks stage 3 cross compilation.. E.g:

nix build -Lf. pkgsCross.armv7l-hf-multiplatform.python3.pkgs.libcst

I'm putting this in draft.

[doronbehar]

Now everything should be working. Waiting for your review @DavHau & @Aleksanaa .

[ElvishJerricco]

This fixes #480467 though I can't say I understand why; whenever I see references to targetPlatform I suspect something is not quite right :P

(In particular for my use case, cross-compiled image.repart images rely on buildPackages.black at build time, which exhibits the bug)

[uninsane]

This fixes #480467 though I can't say I understand why;

#476822 is the "real" issue here. e.g., the other fix for #480467 was to just axe the custom splicing logic from python packages and let lib.mkScopeWithSplicing do its job:

diff --git a/pkgs/development/interpreters/python/cpython/default.nix b/pkgs/development/interpreters/python/cpython/default.nix
index 13ede05bf2b7..ec88d1e72703 100644
--- a/pkgs/development/interpreters/python/cpython/default.nix
+++ b/pkgs/development/interpreters/python/cpython/default.nix
@@ -171,10 +171,9 @@ let
         attr:
         let
           python = attr.override (
-            inputs'
-            // {
+           {
               self = python;
-              __splices = splices;
             }
           );
         in

[doronbehar]

#476822 is the "real" issue here.

Thanks for the link ! @alois31 should be aware that this PR should work-around the substantial issue presented there. And damn you are right @uninsane - what you suggested seems right and it fixes the issue too, while not even triggering any rebuilds! See:

• python3: let lib.makeScopeWithSplicing' do its job #482863

This PR should be reverted if the above is accepted.

[doronbehar]

@Aleksanaa & @ElvishJerricco , I'd like to merge the PR that reverts this:

• python3.pkgs.setuptools-rust: Revert "adjust setupHook inclusion condition" #482866

Before this PR reaches staging-next and master. I'm 99% sure #482866 is a more proper solution solution, and it targets master because it doesn't trigger too many rebuilds.