Take a broken nixpkgs behaviour re overriding Python interpreter into account#420
Open
adisbladis wants to merge 1 commit intomasterfrom
Open
Take a broken nixpkgs behaviour re overriding Python interpreter into account#420adisbladis wants to merge 1 commit intomasterfrom
adisbladis wants to merge 1 commit intomasterfrom
Conversation
… account. When overriding the Python interpreter pre NixOS/nixpkgs@6421482 all non-derivation values were passed down to the various Python interpreter variants (such as pythonOnBuildForHost) too. We can work around this broken behaviour for native builds by only considering the one overriden Python attribute, ignoring it's sub-variants. This also has the advantage of possibly using less memory as we don't have to instantiate the same derivation yet again. Cross compiled Python's would require a nixpkgs fix to propagate it's overriden settings to the build variants, but for cross it's also not very likely to matter as the build Python isn't what you normally care about customising.
|
This does fix the problem, though NixOS/nixpkgs#498251 does too and I think that might make more sense to use than introducing a workaround for a nixpkgs bug that exists for (hopefully) no more than 3 weeks' worth of versions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When overriding the Python interpreter pre NixOS/nixpkgs@6421482 all non-derivation values were passed down to the various Python interpreter variants (such as pythonOnBuildForHost) too.
We can work around this broken behaviour for native builds by only considering the one overriden Python attribute, ignoring it's sub-variants. This also has the advantage of possibly using less memory as we don't have to instantiate the same derivation yet again.
Cross compiled Python's would require a nixpkgs fix to propagate it's overriden settings to the build variants, but for cross it's also not very likely to matter as the build Python isn't what you normally care about customising.