Skip to content

nodejs: make nodejs_* depend on nodejs-slim_*#481461

Merged
aduh95 merged 1 commit intoNixOS:stagingfrom
aduh95:node-slim-and-npm
Feb 6, 2026
Merged

nodejs: make nodejs_* depend on nodejs-slim_*#481461
aduh95 merged 1 commit intoNixOS:stagingfrom
aduh95:node-slim-and-npm

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 18, 2026 •
edited
Loading

Things done

Having nodejs-slim and nodejs building the same software twice is a waste of resources. Opening as draft as the patches need to be ported to the new package.

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

SuperSandro2000
SuperSandro2000 reviewed Jan 19, 2026
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Jan 19, 2026
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 20, 2026
@aduh95 aduh95 mentioned this pull request Jan 20, 2026
Merged
13 tasks
@aduh95 aduh95 force-pushed the node-slim-and-npm branch from a881a64 to f43e689 Compare January 21, 2026 11:02
github-actions[bot]

This comment was marked as outdated.

Sign in to view

@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 21, 2026
@aduh95 aduh95 force-pushed the node-slim-and-npm branch from f43e689 to a4192a0 Compare January 21, 2026 15:38
@github-actions github-actions bot dismissed their stale review January 21, 2026 15:39

Review dismissed automatically

@aduh95 aduh95 force-pushed the node-slim-and-npm branch 5 times, most recently from 3fddf6c to 264cd1e Compare January 21, 2026 22:21
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: R R is a programming language for statistical computing and data visualization. labels Jan 21, 2026
@aduh95 aduh95 marked this pull request as ready for review January 21, 2026 22:27
@aduh95 aduh95 force-pushed the node-slim-and-npm branch from 264cd1e to eacff34 Compare January 21, 2026 22:37
@aduh95 aduh95 force-pushed the node-slim-and-npm branch from bbfda79 to bca6ea3 Compare January 23, 2026 09:59
@aduh95 aduh95 changed the title nodejs: refactor npm to a separate package nodejs: make nodejs_* depend on nodejs-slim_* Jan 23, 2026
@aduh95
Copy link
Contributor Author

aduh95 commented Jan 23, 2026

@ofborg build nodejs_25 nodejs_25.passthru.tests nodejs_22 nodejs_22.passthru.tests nodejs_20 nodejs_20.passthru.tests

@aduh95
Copy link
Contributor Author

aduh95 commented Jan 24, 2026

I think the current state of the PR matches @Ma27's suggestion – and thanks, it's indeed much more elegant that way. Are there more suggestions / concerns?

Ma27
Ma27 reviewed Jan 25, 2026
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested this, but the change looks reasonable to me 👍

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 25, 2026
@aduh95 aduh95 force-pushed the node-slim-and-npm branch from bca6ea3 to 16bd047 Compare January 25, 2026 17:28
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 25, 2026
@aduh95 aduh95 force-pushed the node-slim-and-npm branch from 16bd047 to 6701935 Compare January 25, 2026 17:36
wolfgangwalther
wolfgangwalther reviewed Jan 28, 2026
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might also want to add an outputCheck, to confirm that none of the regular outputs refer to the npm output, to avoid pulling that in accidentally at run-time (?).

(you'll need to enable __structuredAttrs for that if that's not the case already)

@aduh95 aduh95 force-pushed the node-slim-and-npm branch 3 times, most recently from a7bc1ee to 4381a17 Compare February 1, 2026 22:20
@aduh95 aduh95 force-pushed the node-slim-and-npm branch from 4381a17 to 7459fe9 Compare February 3, 2026 22:54
@nixpkgs-ci nixpkgs-ci bot added 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation labels Feb 3, 2026
@aduh95
Copy link
Contributor Author

aduh95 commented Feb 3, 2026

If there are no more suggestions, I'll land this in 48 hours

@aduh95 aduh95 added this pull request to the merge queue Feb 6, 2026
Merged via the queue into NixOS:staging with commit dbcb81f Feb 6, 2026
30 of 32 checks passed
@aduh95 aduh95 deleted the node-slim-and-npm branch February 6, 2026 19:06
@dotlambda
Copy link
Member

dotlambda commented Feb 6, 2026

So now we should migrate packages that use yarn or pnpm to nodejs-slim?

This was referenced Feb 6, 2026
Merged
Merged
misumisumi pushed a commit to misumisumi/flakes that referenced this pull request Feb 24, 2026
fix(node-packages): replace to nodejs-slim from nodejs due to NixOS/n…
4eced12 
…ixpkgs#481461
misumisumi added a commit to misumisumi/flakes that referenced this pull request Feb 27, 2026
@misumisumi
Merge pull request #204 from misumisumi/fix/node
dd76b76 
fix(node-packages): replace to nodejs-slim from nodejs due to NixOS/nixpkgs#481461
@cameronraysmith cameronraysmith mentioned this pull request Feb 27, 2026
Closed
@aduh95 aduh95 mentioned this pull request Mar 6, 2026
Merged
13 tasks
@kmillikin kmillikin mentioned this pull request Mar 17, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ma27 Ma27 Ma27 left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@wolfgangwalther wolfgangwalther wolfgangwalther left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@bjornfor bjornfor Awaiting requested review from bjornfor

@DimitarNestorov DimitarNestorov Awaiting requested review from DimitarNestorov

@jbedo jbedo Awaiting requested review from jbedo

@kashw2 kashw2 Awaiting requested review from kashw2

@me-and me-and Awaiting requested review from me-and

@philiptaron philiptaron Awaiting requested review from philiptaron

@prusnak prusnak Awaiting requested review from prusnak

@raboof raboof Awaiting requested review from raboof

@talyz talyz Awaiting requested review from talyz

@thiagokokada thiagokokada Awaiting requested review from thiagokokada

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@wmertens wmertens Awaiting requested review from wmertens

@zivarah zivarah Awaiting requested review from zivarah

Assignees

No one assigned

Labels

6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: R R is a programming language for statistical computing and data visualization. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95 @Ma27 @wolfgangwalther @dotlambda @SuperSandro2000