Skip to content

treewide: use nodejs-slim when accessing only node#487737

Merged
aduh95 merged 1 commit intoNixOS:stagingfrom
aduh95:nodejs-slim-everyone
Feb 7, 2026
Merged

treewide: use nodejs-slim when accessing only node#487737
aduh95 merged 1 commit intoNixOS:stagingfrom
aduh95:nodejs-slim-everyone

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 6, 2026

Things done

With #481461 landed, there's an incentive to use the -slim varients when not using npm. I've searched for all the occurences where only the node binary is called.

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot requested review from Lassulus, Ma27 and Profpatsch February 6, 2026 19:59
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: jitsi VoIP and instant messaging application with video conferencing capabilities labels Feb 6, 2026
wolfgangwalther
wolfgangwalther approved these changes Feb 7, 2026
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM; did not build.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 7, 2026
@aduh95 aduh95 added this pull request to the merge queue Feb 7, 2026
Merged via the queue into NixOS:staging with commit ac7753a Feb 7, 2026
32 checks passed
@aduh95 aduh95 deleted the nodejs-slim-everyone branch February 7, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

@Lassulus Lassulus Awaiting requested review from Lassulus

@Ma27 Ma27 Awaiting requested review from Ma27

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

Assignees

No one assigned

Labels

6.topic: jitsi VoIP and instant messaging application with video conferencing capabilities 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aduh95 @wolfgangwalther