fix: fall back to nodejs-slim.src when nodejs.src is absent#19
Closed
cameronraysmith wants to merge 1 commit intopietdevries94:mainfrom
Closed
fix: fall back to nodejs-slim.src when nodejs.src is absent#19cameronraysmith wants to merge 1 commit intopietdevries94:mainfrom
cameronraysmith wants to merge 1 commit intopietdevries94:mainfrom
Conversation
nixpkgs PR 481461 restructured nodejs_* from mkDerivation to symlinkJoin over nodejs-slim_*, removing the src attribute. Use nix or-default to fall back to pkgs.nodejs-slim.src for native binding compilation headers.
|
Nevermind, this seems to work as an overlay: overlay = final: prev: {
nodejs = prev.nodejs // {
inherit (prev.nodejs-slim) src;
};
playwright-driver = final.callPackage "${playwright}/playwright-driver" { };
playwright-test = final.callPackage "${playwright}/playwright-test/wrapped.nix" { };
};Although it would probably still be better if playwright-web-flake just exposed an overlay because then we didn't have to replicate the |
Collaborator
|
With #18, it looks like this is not relevant anymore as it removes this bit of code entirely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NixOS/nixpkgs#481461 restructured
nodejs_*frommkDerivationtosymlinkJoinovernodejs-slim_*, dropping thesrcattribute. This breaksplaywright-web-flake/playwright-test/node-env.nix
Line 211 in f6342a8
--nodedir.nodejs.src or pkgs.nodejs-slim.srcworks on nixpkgs revisions predating the change and resolves the missing attr on current nixpkgs-unstable.