Skip to content

corepack: use nodejs-slim#482047

Merged
dotlambda merged 1 commit intoNixOS:masterfrom
dotlambda:corepack
Feb 3, 2026
Merged

corepack: use nodejs-slim#482047
dotlambda merged 1 commit intoNixOS:masterfrom
dotlambda:corepack

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Jan 20, 2026

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@dotlambda dotlambda mentioned this pull request Jan 20, 2026
Merged
13 tasks
@aduh95
Copy link
Contributor

aduh95 commented Jan 20, 2026

FYI I was planing on addressing that only after #481461 was done as using both nodejs-slim and nodejs is kinda awkward at the moment (you have to download twice the same software)

@nixpkgs-ci nixpkgs-ci bot requested a review from aduh95 January 20, 2026 19:38
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 20, 2026
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 20, 2026
pinage404
pinage404 reviewed Jan 20, 2026
View reviewed changes
Copy link
Contributor

@pinage404 pinage404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built locally and tested, it still works

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 20, 2026
@dotlambda dotlambda added this pull request to the merge queue Feb 3, 2026
Merged via the queue into NixOS:master with commit f953084 Feb 3, 2026
38 of 40 checks passed
@dotlambda dotlambda deleted the corepack branch February 3, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes

+1 more reviewer

@pinage404 pinage404 pinage404 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dotlambda @aduh95 @pinage404