Skip to content

nodejs: add a corepack output#487796

Merged
aduh95 merged 1 commit intoNixOS:stagingfrom
aduh95:nodejs-corepack-output
Feb 7, 2026
Merged

nodejs: add a corepack output#487796
aduh95 merged 1 commit intoNixOS:stagingfrom
aduh95:nodejs-corepack-output

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 6, 2026

Things done

Similar to #481461, we can decouple corepack to its own output.
Fixes: #482918

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 8.has: changelog This PR adds or changes release notes 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 8.has: documentation This PR adds or changes documentation labels Feb 6, 2026
philiptaron
philiptaron approved these changes Feb 7, 2026
View reviewed changes
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, I do want all those things out of all-packages.nix if possible

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Feb 7, 2026
@aduh95 aduh95 force-pushed the nodejs-corepack-output branch from 67858db to 68381b5 Compare February 7, 2026 10:17
@aduh95 aduh95 added this pull request to the merge queue Feb 7, 2026
Merged via the queue into NixOS:staging with commit 93729d6 Feb 7, 2026
25 checks passed
@aduh95 aduh95 deleted the nodejs-corepack-output branch February 7, 2026 22:43
@aduh95 aduh95 mentioned this pull request Feb 9, 2026
Closed
3 tasks
@CobaltCause
Copy link
Contributor

CobaltCause commented Mar 2, 2026

So pkgs.corepack has been failing to build on nixos-unstable (example) and I bisected it to this PR. I'm not super familiar with the JS ecosystem but I seem to have been able to work around this by replacing pkgs.corepack with pkgs.nodejs-slim.corepack (new in this PR). Was the breakage to pkgs.corepack intentional? Is my workaround the right course of action?

@aduh95 aduh95 mentioned this pull request Mar 2, 2026
Merged
13 tasks
@apgrucza apgrucza mentioned this pull request Mar 5, 2026
Open
@aduh95 aduh95 mentioned this pull request Mar 6, 2026
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philiptaron philiptaron philiptaron approved these changes

@bjornfor bjornfor Awaiting requested review from bjornfor

@DimitarNestorov DimitarNestorov Awaiting requested review from DimitarNestorov

@kashw2 kashw2 Awaiting requested review from kashw2

@me-and me-and Awaiting requested review from me-and

@prusnak prusnak Awaiting requested review from prusnak

@thiagokokada thiagokokada Awaiting requested review from thiagokokada

@wmertens wmertens Awaiting requested review from wmertens

@zivarah zivarah Awaiting requested review from zivarah

Assignees

No one assigned

Labels

6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aduh95 @CobaltCause @philiptaron