Skip to content

python3Packages.chromadb_0: drop#416834

Merged
dotlambda merged 1 commit intoNixOS:masterfrom
dotlambda:python3Packages.chromadb
Jun 15, 2025
Merged

python3Packages.chromadb_0: drop#416834
dotlambda merged 1 commit intoNixOS:masterfrom
dotlambda:python3Packages.chromadb

Conversation

@dotlambda
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested review from GaetanLepage and natsukium June 15, 2025 00:22
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 6.topic: python Python is a high-level, general-purpose programming language. labels Jun 15, 2025
@dotlambda dotlambda merged commit 9899b48 into NixOS:master Jun 15, 2025
13 of 16 checks passed
@dotlambda dotlambda deleted the python3Packages.chromadb branch June 15, 2025 00:26
with python3Packages;
[
chromadb_0
chromadb
Copy link
Contributor

@MattSturgeon MattSturgeon Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes a build failure.

vectorcode> Successfully built vectorcode-0.6.10-py3-none-any.whl
vectorcode> Finished creating a wheel...
vectorcode> Finished executing pypaBuildPhase
vectorcode> Running phase: pythonRuntimeDepsCheckHook
vectorcode> Executing pythonRuntimeDepsCheck
vectorcode> Checking runtime dependencies for vectorcode-0.6.10-py3-none-any.whl
vectorcode>   - chromadb<=0.6.3 not satisfied by version 1.0.12
error: builder for '/nix/store/591i8lhlrb3wrjz3vjsbwm2fz4ax7dpx-vectorcode-0.6.10.drv' failed with exit code 1;

If the package's version ranges are just overzealous, we can use pythonRelaxDepsHook to resolve the issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on #415770 (comment) and Davidyz/VectorCode#164, relaxing the dependencies may not be an option.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for linking to the context!

Based on that, I'd say this PR should have waited until the _0 package was moved into vectorcode. There shouldn't have been any urgency, at least not enough urgency to justify breaking things 😅

Thanks for addressing it in #417720 though. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants