vectorcode: pin chromadb at 0.6.3#417720
Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom Jun 18, 2025
Merged
Conversation
Contributor
|
@dotlambda Please revert the original chromadb_0 commit. I'm out sick (basically stuck in bed) so I must delegate. |
Contributor
IIUC #416834 effectively already reverted it; but without actually using
Sorry to hear! |
Contributor
MattSturgeon
left a comment
There was a problem hiding this comment.
Thanks for handling this!
Contributor
There was a problem hiding this comment.
The prior _0 package had checks (except on arm linux).
Ideally we'd keep them.
What's the reason for dropping them here?
Member
Author
There was a problem hiding this comment.
I couldn't get them to work, see e.g. #417287.
Feel free to work on the tests.
GaetanLepage
approved these changes
Jun 18, 2025
This was referenced Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.