Skip to content

python3Packages.chromadb_0: drop #416834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dotlambda merged 1 commit into from
Jun 15, 2025
Merged

python3Packages.chromadb_0: drop #416834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkgs/by-name/ve/vectorcode/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ python3Packages.buildPythonApplication rec {
dependencies =
with python3Packages;
[
chromadb_0
chromadb
Copy link
Contributor

@MattSturgeon MattSturgeon Jun 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes a build failure.

vectorcode> Successfully built vectorcode-0.6.10-py3-none-any.whl
vectorcode> Finished creating a wheel...
vectorcode> Finished executing pypaBuildPhase
vectorcode> Running phase: pythonRuntimeDepsCheckHook
vectorcode> Executing pythonRuntimeDepsCheck
vectorcode> Checking runtime dependencies for vectorcode-0.6.10-py3-none-any.whl
vectorcode>   - chromadb<=0.6.3 not satisfied by version 1.0.12
error: builder for '/nix/store/591i8lhlrb3wrjz3vjsbwm2fz4ax7dpx-vectorcode-0.6.10.drv' failed with exit code 1;

If the package's version ranges are just overzealous, we can use pythonRelaxDepsHook to resolve the issue.

Copy link
Contributor

@MattSturgeon MattSturgeon Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on #415770 (comment) and Davidyz/VectorCode#164, relaxing the dependencies may not be an option.

Copy link
Member Author

@dotlambda dotlambda Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #412528 (comment).

Copy link
Contributor

@MattSturgeon MattSturgeon Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for linking to the context!

Based on that, I'd say this PR should have waited until the _0 package was moved into vectorcode. There shouldn't have been any urgency, at least not enough urgency to justify breaking things 😅

Thanks for addressing it in #417720 though. 🎉

colorlog
httpx
json5
Expand Down
220 changes: 0 additions & 220 deletions pkgs/development/python-modules/chromadb/0.nix
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions pkgs/top-level/python-packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2473,8 +2473,6 @@ self: super: with self; {

chromadb = callPackage ../development/python-modules/chromadb { };

chromadb_0 = callPackage ../development/python-modules/chromadb/0.nix { };

chromaprint = callPackage ../development/python-modules/chromaprint { };

ci-info = callPackage ../development/python-modules/ci-info { };
Expand Down