python3Packages.chromadb: fixes#412528
Merged
GaetanLepage merged 6 commits intoNixOS:masterfrom Jun 8, 2025
Merged
Conversation
github-actions
bot
added
6.topic: python
github-actions
bot
added
10.rebuild-darwin: 11-100
sarahec
force-pushed
the
bump-chromadb
branch
3 times, most recently
from
14d2ff3 to
4d37579
Compare
sarahec
changed the title
github-actions
bot
added
the
8.has: documentation
Contributor
Author
|
@fabaff Please take a look. |
Contributor
|
Last of the pre-1.0.0 releases. Required by some legacy AI packages. changelog: https://github.com/chroma-core/chroma/releases/tag/0.6.3
Pins old version to support legacy AI packages.
sarahec
added
12.approvals: 1
kirillrdy
approved these changes
Jun 7, 2025
sarahec
added
12.approvals: 2
dotlambda
reviewed
Jun 15, 2025
Member
dotlambda
left a comment
dotlambda
left a comment
There was a problem hiding this comment.
@GaetanLepage This is unacceptable.
|
|
||
| chromadb = callPackage ../development/python-modules/chromadb { }; | ||
|
|
||
| chromadb_0 = callPackage ../development/python-modules/chromadb/0.nix { }; |
Member
There was a problem hiding this comment.
We don't do versioned attributes in python3Packages! Only for very exceptional cases.
Contributor
There was a problem hiding this comment.
Sorry. I knew that this should be avoided, but could be done when necessary. It seemed legit in this case.
Is there a reference describing what would be qualified as an "exceptional case"?
Member
There was a problem hiding this comment.
I don't think so. But one necessary condition should be that it's used more than once across nixpkgs.
Contributor
There was a problem hiding this comment.
But one necessary condition should be that it's used more than once across nixpkgs.
That's fair indeed.
Contributor
Author
There was a problem hiding this comment.
How does this plan sound:
- I'll move the chromadb 0.6.3 derivation into its one client (
vectorcode) under alet. - I'll revert the chromadb_0 commit
- I'll edit
chromadb1.0.x to put the maturin build hook innativeBuildInputs
Is that acceptable?
Member
There was a problem hiding this comment.
Should be inside packageOverrides inside let.
| with python3Packages; | ||
| [ | ||
| chromadb | ||
| chromadb_0 |
Contributor
Author
There was a problem hiding this comment.
Sorry, I'll fix it.
dotlambda
reviewed
Jun 15, 2025
| build-system = [ | ||
| setuptools | ||
| setuptools-scm | ||
| rustPlatform.maturinBuildHook |
Member
There was a problem hiding this comment.
This belongs in nativeBuildInputs as it's not a Python package.
dotlambda
reviewed
Jun 15, 2025
| protobuf, | ||
| rustc, | ||
| rustPlatform, | ||
| pkgs, # zstd hidden by python3Packages.zstd |
Member
There was a problem hiding this comment.
Use zstd-c and set zstd-c = pkgs.zstd in python-packages.nix.
13 tasks
13 tasks
GaetanLepage
pushed a commit
that referenced
this pull request
Jun 24, 2025
On aarch64-linux onnxruntime cannot be imported, as it attempts to read /sys/devices/system/cpu, which does not exist in the sandbox. As onnxruntime cannot be imported, chromadb cannot be tested. However, this issue only applies in the build sandbox, not at runtime. Therefore the package doesn't need to be marked broken. Updated the condition to check `buildPlatform` instead of `hostPlatform`, as the issue relates to the build sandbox and is not a runtime issue. Use `isAarch` and `isLinux` attributes instead of doing string comparison. --- See #412528 (comment) And upstream onnxruntime issue: microsoft/onnxruntime#10038
chrisportela
pushed a commit
to chrisportela/nixpkgs
that referenced
this pull request
Jul 3, 2025
On aarch64-linux onnxruntime cannot be imported, as it attempts to read /sys/devices/system/cpu, which does not exist in the sandbox. As onnxruntime cannot be imported, chromadb cannot be tested. However, this issue only applies in the build sandbox, not at runtime. Therefore the package doesn't need to be marked broken. Updated the condition to check `buildPlatform` instead of `hostPlatform`, as the issue relates to the build sandbox and is not a runtime issue. Use `isAarch` and `isLinux` attributes instead of doing string comparison. --- See NixOS#412528 (comment) And upstream onnxruntime issue: microsoft/onnxruntime#10038
13 tasks
Contributor
|
I believe this PR broke the nixos module test for chromadb, it seems to have gone from passing to not passing after it #442520 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chromadb: updates and backwards compatibility
with libin meta blockpython3Packages.chromadb_0. Many packages in the AI ecosystem aren't ready for 1.0 and can usechromadb_0.Dependents
python3Packages.langchain-chromato 0.2.4 which needs chromadb >= 1.0.9vectorcodeto usechroma_0Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.