Skip to content

Comments

electron_34-bin: fix read out of range on aarch64 16k pages systems#382497

Merged
emilylange merged 1 commit intoNixOS:masterfrom
emilylange:electron_34-aarch64-16k-pagesize
Feb 17, 2025
Merged

electron_34-bin: fix read out of range on aarch64 16k pages systems#382497
emilylange merged 1 commit intoNixOS:masterfrom
emilylange:electron_34-aarch64-16k-pagesize

Conversation

@emilylange
Copy link
Member

@emilylange emilylange commented Feb 16, 2025

Previously in chromium (source build): #365364 (608b73b)

This works around a regression in chromium M131-134 that causes electron v33 and v34 on aarch64-linux with 16k pagesize (e.g. Asahi Linux) to crash.

This commit applies this workaround only to electron v34, as v33.4.1, for which we have a soon to be merged PR open (#382361), already carries the workaround upstream.

Ref #379886, #380991 and #380617.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Previously in chromium (source build): 608b73b

This works around a regression in chromium M131-134 that causes electron
v33 and v34 on aarch64-linux with 16k pagesize (e.g. Asahi Linux) to
crash.

This commit applies this workaround only to electron v34, as v33.4.1,
for which we have a soon to be merged PR open, already carries the
workaround upstream.
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Feb 16, 2025
@nix-owners nix-owners bot requested review from teutat3s and yayayayaka February 16, 2025 06:10
@emilylange emilylange mentioned this pull request Feb 16, 2025
13 tasks
@emilylange emilylange merged commit fca94f7 into NixOS:master Feb 17, 2025
36 checks passed
@emilylange emilylange deleted the electron_34-aarch64-16k-pagesize branch February 17, 2025 13:01
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Feb 17, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants