electron_34-bin: fix read out of range on aarch64 16k pages systems#382497
Merged
emilylange merged 1 commit intoNixOS:masterfrom Feb 17, 2025
Merged
electron_34-bin: fix read out of range on aarch64 16k pages systems#382497emilylange merged 1 commit intoNixOS:masterfrom
emilylange merged 1 commit intoNixOS:masterfrom
Conversation
Previously in chromium (source build): 608b73b This works around a regression in chromium M131-134 that causes electron v33 and v34 on aarch64-linux with 16k pagesize (e.g. Asahi Linux) to crash. This commit applies this workaround only to electron v34, as v33.4.1, for which we have a soon to be merged PR open, already carries the workaround upstream.
13 tasks
teutat3s
approved these changes
Feb 16, 2025
Contributor
|
Successfully created backport PR for |
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously in chromium (source build): #365364 (608b73b)
This works around a regression in chromium M131-134 that causes electron v33 and v34 on aarch64-linux with 16k pagesize (e.g. Asahi Linux) to crash.
This commit applies this workaround only to electron v34, as v33.4.1, for which we have a soon to be merged PR open (#382361), already carries the workaround upstream.
Ref #379886, #380991 and #380617.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)