Skip to content

obsidian: pin electron to 33#380617

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
w-lfchen:obsidian/pin-electron
Feb 10, 2025
Merged

obsidian: pin electron to 33#380617
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
w-lfchen:obsidian/pin-electron

Conversation

@w-lfchen
Copy link
Member

@w-lfchen w-lfchen commented Feb 9, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 9, 2025
@ddogfoodd
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380617


x86_64-linux

✅ 1 package built:
  • obsidian

Copy link
Contributor

@ddogfoodd ddogfoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! still works for me on x86_64-linux, we just need someone to confirm it fixes the issue now

@mogery
Copy link
Contributor

mogery commented Feb 10, 2025

Tried this on aarch64-linux (M1 MacBook Air) and it works wonderfully!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 10, 2025
@waltmck
Copy link

waltmck commented Feb 10, 2025

This fixes the issue for me also on aarch64-linux (M2 Macbook Air).

@SuperSandro2000 SuperSandro2000 changed the title obsidian: pin electron to v33 obsidian: pin electron to 33 Feb 10, 2025
@SuperSandro2000 SuperSandro2000 merged commit 789df15 into NixOS:master Feb 10, 2025
36 checks passed
@waltmck waltmck mentioned this pull request Feb 10, 2025
13 tasks
@emilylange
Copy link
Member

#382497 was just merged, meaning the downgrade to electron 33 can be reverted again, if you want.

@w-lfchen
Copy link
Member Author

thank you for the heads up <3
i don't think it matters much, so i think it'd be best to incorporate it with the next version bump

@w-lfchen w-lfchen deleted the obsidian/pin-electron branch February 18, 2025 15:02
@w-lfchen w-lfchen mentioned this pull request Feb 18, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

obsidian: rendering on Asahi Linux broken with nixpkgs version but works with AppImage

7 participants