chromium: fix read out of range on aarch64 16k pages builds#365364
chromium: fix read out of range on aarch64 16k pages builds#365364emilylange merged 1 commit intoNixOS:masterfrom
Conversation
d422909 to
2356ced
Compare
|
Posting the log indicating the issue for easier googling: |
|
I've built that and it seems to fix og issue with tabs crashing, but now I can no longer play yt videos. Gonna check this further before undraft |
|
This PR is important as chromium based browsers the only way for me (and possibly all mac asahi nix users) to use progressive web apps like Slack for communication. Blocking nixos as daily driver. |
|
Additional context: https://social.treehouse.systems/@marcan/113656361610223289 |
|
Alright, tested youtube and slack huddles and everything works, undrafting. |
Co-authored-by: networkException <github@nwex.de>
b4aa634 to
608b73b
Compare
networkException
left a comment
There was a problem hiding this comment.
Very nice, thank you
|
Successfully created backport PR for |
|
Hello, I'm not familiar with how this works, but does this mean all the other Chromium-based browsers, such as Brave, need to be patched as well? Thank you. |
|
Yes, unless patched by their respective upstream, this problem affects all chromium based browsers. As far as nixpkgs goes only chromium and ungoogled-chromium are built from source. Google Chrome for example couldn't be patched because its proprietary |
|
@sayidabyan For brave (and any other chromium based browser) you can still bypass this option using the following command when launching the app from commandline brave --js-flags=--no-decommit-pooled-pagessee this discussion nix-community/nixos-apple-silicon#259 |
This fixes an issue introduced in chromium 131 which results in out of range memory reads on 16k pages systems.
Revert v8 change. Here it was done for fedora asahi remix.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.