Skip to content

Comments

chromium: fix read out of range on aarch64 16k pages builds#365364

Merged
emilylange merged 1 commit intoNixOS:masterfrom
zvolin:fix/chromium-asahi-16k-pages
Dec 18, 2024
Merged

chromium: fix read out of range on aarch64 16k pages builds#365364
emilylange merged 1 commit intoNixOS:masterfrom
zvolin:fix/chromium-asahi-16k-pages

Conversation

@zvolin
Copy link
Contributor

@zvolin zvolin commented Dec 15, 2024

This fixes an issue introduced in chromium 131 which results in out of range memory reads on 16k pages systems.

Revert v8 change. Here it was done for fedora asahi remix.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 15, 2024
@zvolin zvolin force-pushed the fix/chromium-asahi-16k-pages branch 4 times, most recently from d422909 to 2356ced Compare December 15, 2024 19:19
@zvolin
Copy link
Contributor Author

zvolin commented Dec 15, 2024

Posting the log indicating the issue for easier googling:

ERROR:process_memory_range.cc(75)] read out of range

@zvolin
Copy link
Contributor Author

zvolin commented Dec 15, 2024

I've built that and it seems to fix og issue with tabs crashing, but now I can no longer play yt videos. Gonna check this further before undraft

@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 16, 2024
@reinthal
Copy link

reinthal commented Dec 16, 2024

This PR is important as chromium based browsers the only way for me (and possibly all mac asahi nix users) to use progressive web apps like Slack for communication. Blocking nixos as daily driver.

@networkException
Copy link
Member

networkException commented Dec 16, 2024

@zvolin
Copy link
Contributor Author

zvolin commented Dec 16, 2024

Alright, tested youtube and slack huddles and everything works, undrafting.
I think my issue with youtube was with the sound handling as I was testing before with nix run .#chromium in nixpkgs rather than by including chromium in my nixos config, which applies asahi overlay magic with sound drivers etc.

@zvolin zvolin marked this pull request as ready for review December 16, 2024 11:16
Co-authored-by: networkException <github@nwex.de>
@zvolin zvolin force-pushed the fix/chromium-asahi-16k-pages branch from b4aa634 to 608b73b Compare December 16, 2024 12:22
@github-actions github-actions bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 16, 2024
Copy link
Member

@networkException networkException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 16, 2024
@ofborg ofborg bot requested a review from networkException December 16, 2024 20:06
@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 16, 2024
@emilylange emilylange merged commit 5015201 into NixOS:master Dec 18, 2024
4 of 5 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 18, 2024

Successfully created backport PR for release-24.11:

@sayidabyan
Copy link

Hello, I'm not familiar with how this works, but does this mean all the other Chromium-based browsers, such as Brave, need to be patched as well? Thank you.

@networkException
Copy link
Member

Yes, unless patched by their respective upstream, this problem affects all chromium based browsers. As far as nixpkgs goes only chromium and ungoogled-chromium are built from source. Google Chrome for example couldn't be patched because its proprietary

@reinthal
Copy link

@sayidabyan For brave (and any other chromium based browser) you can still bypass this option using the following command when launching the app from commandline

brave --js-flags=--no-decommit-pooled-pages

see this discussion nix-community/nixos-apple-silicon#259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants