Skip to content

Comments

[Backport release-24.11] electron{-source,-bin,-chromedriver}: 32.3.0 -> 32.3.1, 33.4.0 -> 33.4.1, 34.1.1 -> 34.2.0, electron_34-bin: fix read out of range on aarch64 16k pages systems#382813

Merged
emilylange merged 9 commits intorelease-24.11from
backport-382497-to-release-24.11
Feb 17, 2025
Merged

Conversation

@nixpkgs-ci
Copy link
Contributor

@nixpkgs-ci nixpkgs-ci bot commented Feb 17, 2025 •
edited by emilylange
Loading

Bot-based backport to release-24.11, triggered by a label in #382497 and then manually pushed parts of #382361.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@emilylange @github-actions
electron_34-bin: fix read out of range on aarch64 16k pages systems
3c29757 
Previously in chromium (source build): 608b73b

This works around a regression in chromium M131-134 that causes electron
v33 and v34 on aarch64-linux with 16k pagesize (e.g. Asahi Linux) to
crash.

This commit applies this workaround only to electron v34, as v33.4.1,
for which we have a soon to be merged PR open, already carries the
workaround upstream.

(cherry picked from commit 69bab47)
@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Feb 17, 2025
Merged
13 tasks
@emilylange emilylange mentioned this pull request Feb 17, 2025
Merged
13 tasks
@emilylange
electron_32-bin: 32.3.0 -> 32.3.1
507189e 
- Changelog: https://github.com/electron/electron/releases/tag/v32.3.1
- Diff: electron/electron@refs/tags/v32.3.0...v32.3.1

(cherry picked from commit e9e8085)
@emilylange
electron_33-bin: 33.4.0 -> 33.4.1
4747c6c 
- Changelog: https://github.com/electron/electron/releases/tag/v33.4.1
- Diff: electron/electron@refs/tags/v33.4.0...v33.4.1

(cherry picked from commit 51a2d75)
@emilylange
electron_34-bin: 34.1.1 -> 34.2.0
e761634 
- Changelog: https://github.com/electron/electron/releases/tag/v34.2.0
- Diff: electron/electron@refs/tags/v34.1.1...v34.2.0

(cherry picked from commit 00f656d)
@emilylange
electron-source.electron_32: 32.3.0 -> 32.3.1
9319ae8 
- Changelog: https://github.com/electron/electron/releases/tag/v32.3.1
- Diff: electron/electron@refs/tags/v32.3.0...v32.3.1

(cherry picked from commit 6b1989f)
@emilylange
electron-source.electron_33: 33.4.0 -> 33.4.1
8b7527d 
- Changelog: https://github.com/electron/electron/releases/tag/v33.4.1
- Diff: electron/electron@refs/tags/v33.4.0...v33.4.1

(cherry picked from commit 003f8f4)
@emilylange
electron-chromedriver_32: 32.3.0 -> 32.3.1
27dd21a 
- Changelog: https://github.com/electron/electron/releases/tag/v32.3.1
- Diff: electron/electron@refs/tags/v32.3.0...v32.3.1

(cherry picked from commit 4b382b0)
@emilylange
electron-chromedriver_33: 33.4.0 -> 33.4.1
78fd0f2 
- Changelog: https://github.com/electron/electron/releases/tag/v33.4.1
- Diff: electron/electron@refs/tags/v33.4.0...v33.4.1

(cherry picked from commit 85c576b)
@emilylange
electron-chromedriver_34: 34.1.1 -> 34.2.0
7ec306f 
- Changelog: https://github.com/electron/electron/releases/tag/v34.2.0
- Diff: electron/electron@refs/tags/v34.1.1...v34.2.0

(cherry picked from commit 6dc8694)
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 17, 2025
@nix-owners nix-owners bot requested review from teutat3s and yayayayaka February 17, 2025 13:09
@emilylange emilylange changed the title [Backport release-24.11] electron_34-bin: fix read out of range on aarch64 16k pages systems [Backport release-24.11] electron{-source,-bin,-chromedriver}: 32.3.0 -> 32.3.1, 33.4.0 -> 33.4.1, 34.1.1 -> 34.2.0, electron_34-bin: fix read out of range on aarch64 16k pages systems Feb 17, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 17, 2025
@emilylange
Copy link
Member

emilylange commented Feb 17, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 382813

x86_64-linux

✅ 85 packages built:
  • affine
  • antares
  • antimatter-dimensions
  • appium-inspector
  • bilibili
  • bitwarden-desktop
  • bitwarden-directory-connector
  • blockbench
  • bruno
  • camunda-modeler
  • caprine
  • chatd
  • drawio
  • drawio-headless
  • electron (electron_33)
  • electron-bin (electron_33-bin)
  • electron-chromedriver (electron-chromedriver_33)
  • electron-chromedriver_32
  • electron-chromedriver_34
  • electron_32
  • electron_32-bin
  • electron_34 (electron_34-bin)
  • element-desktop
  • equibop
  • fcast-receiver
  • feishin
  • follow
  • freetube
  • gfn-electron
  • goofcord
  • headset
  • heroic
  • heroic-unwrapped
  • httptoolkit
  • itch
  • jitsi-meet-electron
  • kando
  • koodo-reader
  • kuro
  • legcord
  • mattermost-desktop
  • morgen
  • mqtt-explorer
  • nix-tour
  • obsidian
  • open-stage-control
  • pandoc-drawio-filter
  • pandoc-drawio-filter.dist
  • pocket-casts
  • podman-desktop
  • pritunl-client
  • proton-pass
  • protonmail-desktop
  • python311Packages.mkdocs-drawio-exporter
  • python311Packages.mkdocs-drawio-exporter.dist
  • python312Packages.mkdocs-drawio-exporter
  • python312Packages.mkdocs-drawio-exporter.dist
  • r2modman
  • redisinsight
  • revolt-desktop
  • ride
  • sharedown
  • sieve-editor-gui
  • siyuan
  • standardnotes
  • stretchly
  • super-productivity
  • teams-for-linux
  • terra-station
  • tetrio-desktop
  • thedesk
  • threema-desktop
  • uhk-agent
  • uhk-udev-rules
  • uivonim
  • vesktop
  • vieb
  • webcord
  • webcord-vencord
  • webtorrent_desktop
  • yandex-music
  • youtube-music
  • ytdownloader
  • ytmdesktop
  • zulip

@emilylange emilylange merged commit 85142e3 into release-24.11 Feb 17, 2025
41 of 43 checks passed
@emilylange emilylange deleted the backport-382497-to-release-24.11 branch February 17, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teutat3s teutat3s teutat3s approved these changes

@yayayayaka yayayayaka Awaiting requested review from yayayayaka

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emilylange @teutat3s