matomo: refactor, matomo-beta: remove#374022
Conversation
8a133e3 to
4e557b0
Compare
726b78d to
36d489d
Compare
|
The large test changes might clash with #373894, let's see how this goes. |
osnyx
left a comment
There was a problem hiding this comment.
Code LGTM, still waiting for the aarch64 CI runs.
If you prefer I can undo most test-related changes and only apply the removal of matomo-beta to the tests. |
|
@niklaskorz Let's keep your test-related changes, the test diff for #373894 is pretty small. So if we commit to merging this PR first, I can rebase and adjust my PR. |
|
Although, now that I think of it, #373894 might be a bit more urgent and it's important that it can be backported to 24.11. Because the matomo-5.2.x there currently is affected by the issue fixed there. |
In that case feel free to merge that first and I can rebase this PR afterwards. I'll also review your PR in a moment. |
cb4d84d to
50b42fe
Compare
|
Rebased and resolved conflicts with changes from #373894 |
50b42fe to
7c2e8f1
Compare
|
@leona-ya Are we still waiting for feedback from other maintainers or can this be merged? |
|
I've been waiting to see if other people want to review it, but it's long enough now, I think. |
Reasonable and thanks for the clarification :) |
matomo.overrideAttrs, e.g.:Once this is merged, I will make a follow-up PR on release-24.11 to make automatic backports possible again, as the last few updates had to be manually backported due to the rename of
matomo_5tomatomo.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.