nixos/matomo: fix service failure when not fully set up#373894
Merged
leona-ya merged 2 commits intoNixOS:masterfrom Jan 15, 2025
Merged
nixos/matomo: fix service failure when not fully set up#373894leona-ya merged 2 commits intoNixOS:masterfrom
leona-ya merged 2 commits intoNixOS:masterfrom
Conversation
Since matomo-5.2.0, the config.php.ini is already created when first accessing the installer page without completing it. This breaks our discovery of whether to run database migrations. Attempting to run DB migrations without provided database credentials causes a crash -> causing matomo-setup-update.service to fail -> causing phpfpm-matomo.service to fail.
github-actions
bot
added
6.topic: nixos
osnyx
added
backport release-24.11
and removed
6.topic: nixos
github-actions
bot
added
10.rebuild-darwin: 0
13 tasks
niklaskorz
approved these changes
Jan 15, 2025
Member
niklaskorz
left a comment
niklaskorz
left a comment
There was a problem hiding this comment.
Tests are passing, the setup safeguard looks reasonable to me
leona-ya
approved these changes
Jan 15, 2025
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since matomo-5.2.0, the config.php.ini is already created when first
accessing the installer page without completing it. This breaks our
discovery of whether to run database migrations.
Attempting to run DB migrations without provided database credentials
causes a crash -> causing matomo-setup-update.service to fail -> causing
phpfpm-matomo.service to fail.
This is a problem when the service (or the whole system) is restarted during the start, but before the end of the setup process of the web installer. With the
phpfpm-matomo.servicefailing to start due to a failing dependency, finishing up the setup process won't be possible anymore.I have also extended the corresponding NixOS tests to cover aspects we have already been covering in a more detailed downstream test for our own matomo module.
The last test with the
systemctl killwas actually the one revealing the issue fixed here.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.