matomo: ignore prereleases in updateScript and make src overridable#379069
Closed
niklaskorz wants to merge 2 commits intoNixOS:masterfrom
Closed
matomo: ignore prereleases in updateScript and make src overridable#379069niklaskorz wants to merge 2 commits intoNixOS:masterfrom
niklaskorz wants to merge 2 commits intoNixOS:masterfrom
Conversation
bf66396 to
37d8d3a
Compare
Ma27
reviewed
Feb 11, 2025
| }: | ||
|
|
||
| let | ||
| fetchurl' = lib.makeOverridable fetchurl; |
Member
There was a problem hiding this comment.
Any reason fetchurl isn't overridable in the first place?
Member
Author
There was a problem hiding this comment.
To be clear, I don't exactly want fetchurl' = lib.makeOverridable fetchurl to become a widespread pattern, but seeing we removed matomo-beta in unstable, I think in this particular case we still want to make it easy to override the matomo src before that PR lands.
leona-ya
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update script now does its job as seen in #378885, but currently also updates to pre-releases. This is fixed by adding the
--version-regexparameter to the update script.I also noticed today that
fetchurlis not overrideable by default (see #158018), which makes the matomo-beta example in #374022 not work.This is fixed by applying
lib.makeOverridabletofetchurl.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.