Skip to content

[Backport release-24.11] matomo: refactor#379079

Closed
niklaskorz wants to merge 5 commits intoNixOS:release-24.11from
niklaskorz:backport-matomo-refactor
Closed

[Backport release-24.11] matomo: refactor#379079
niklaskorz wants to merge 5 commits intoNixOS:release-24.11from
niklaskorz:backport-matomo-refactor

Conversation

@niklaskorz
Copy link
Member

Manual backport of #374022 to make automatic backports of Matomo 5 updates possible again without introducing breaking changes to Matomo 4 users on NixOS 24.11.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Feb 3, 2025
@niklaskorz
Copy link
Member Author

nixpkgs-vet isn't happy with the workaround I use to allow both automatic backports and keep the package names of 24.11. Any suggestions? :')

@niklaskorz niklaskorz force-pushed the backport-matomo-refactor branch from bbdad56 to dbed5b6 Compare February 3, 2025 11:45
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 3, 2025
@niklaskorz niklaskorz force-pushed the backport-matomo-refactor branch from dbed5b6 to ccc04a3 Compare February 6, 2025 20:12
@niklaskorz
Copy link
Member Author

niklaskorz commented Feb 6, 2025

nixpkgs-vet isn't happy with the workaround I use to allow both automatic backports and keep the package names of 24.11. Any suggestions? :')

The answer was given by https://github.com/NixOS/nixpkgs/tree/master/pkgs/by-name#recommendation-for-new-packages-with-multiple-versions (which suggests the inherit workaround for multi-version package scenarios).

Edit: well, that only applies to packages with version suffixes, not matomo (no suffix), it seems 🫠

@niklaskorz
Copy link
Member Author

It's probably for the best to just keep backporting updates to Matomo 5 manually until the EOL of NixOS 24.11 in June.

@niklaskorz niklaskorz marked this pull request as draft February 7, 2025 18:14
@niklaskorz niklaskorz mentioned this pull request Feb 19, 2025
13 tasks
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 16, 2025
@wolfgangwalther
Copy link
Contributor

Looks like this is not going to happen, so closing.

@niklaskorz niklaskorz deleted the backport-matomo-refactor branch April 27, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants