maintainers/create-amis.sh: add new AWS regions#263075
Closed
anthonyroussel wants to merge 1 commit intoNixOS:masterfrom
Closed
maintainers/create-amis.sh: add new AWS regions#263075anthonyroussel wants to merge 1 commit intoNixOS:masterfrom
anthonyroussel wants to merge 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
anthonyroussel
changed the title
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2821 |
roberth
approved these changes
Oct 26, 2023
delroth
added
the
12.approvals: 1
13 tasks
Member
Author
|
Amazon support will be dropped soon: #269240 |
|
It doesn't sound like all EC2 AMI images will be dropped, possibly just ZFS AMI images, see #269240 (comment) by @arianvp. |
13 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Hello. I think it might be a good idea to update the list of AWS regions available for the NixOS AMI with the upcoming 23.11 release. What do you think?
If it's okay, I think the regions need to be enabled through the NixOS AWS account first, and looks like this part is not automated through Terraform. I don't know who have the rights on the NixOS AWS account to do that.
Also see last update PR: #172855
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)