Conversation
github-actions
bot
added
the
6.topic: nixos
This test has been marked as broken for a long time, it seems that no one is really owning it and this is a waste of our resources. Feel free to revert and add yourself as a maintainer if you care about this.
RaitoBezarius
force-pushed
the
drop-amazon
branch
from
228bfc4 to
e86c6f7
Compare
…maticSize` All of those attributes are broken and given the sad state of AWS maintenance, I am inclined to remove them and stop advertising a support of things that we do not support in fact. Feel free to revert and add yourself as a maintainer.
The release management process involves uploading functional AMIs at each release for NixOS. As this script mentions, the 'entire thing' should be replaced with a new setup involving Terraform. Such a new setup can be found in NixOS/infra#254. In the meantime, this script should not be used anymore until a better solution for AMI uploading is found. This means effectively that AMI uploading is not part of the release management process for further releases. Feel free to push forward the PR mentioned to get back AMI upload.
RaitoBezarius
force-pushed
the
drop-amazon
branch
from
0b9ebcf to
6626120
Compare
github-actions
bot
added
8.has: documentation
|
In the case that the brokenness is not "can't build with Nix" but something else, could you please explain what exactly is broken in the individual commits?
If anybody wants to fix this up now or after the fact, it'd be nice to have the details of what's actually broken (especially since the initial interpretation of "broken" is "the Nix build fails", not "this doesn't work right", at least for me / in this repository) :) |
|
I was wrong about the ZFS image, I was able to finish building it just fine on bcc0da2, though it did take a while: So at least this image doesn't seem broken to me :) |
ofborg
bot
added
10.rebuild-darwin: 0
|
@cole-h Let me get you my traces. |
|
Just to be clear, I'm not signing up to help maintain this stuff (I very, very rarely use AWS EC2), but I think citing the reason for removal as "being broken", when it's not broken, is a bit weird :) |
|
Amazon image: https://clbin.com/TVz4l (initially had a store corrupting bug with hash mismatch at install time, but that's Nix fault.) |
Yeah, you are right, I can be more precise in the individual commits about the reasons. |
|
I will open a PR to add myself as maintainer instead of dropping. I have no interest in maintaining zfs support though as we don't use it At work |
|
There's a pending amis pr #263075 |
|
@arianvp If you can send an ownership taking PR, I will close this one in the time being. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
@RaitoBezarius It would be great if this PR could mention what exactly is being done, instead of referring to dropping "stuff". For example, says there are AMIs at: So it's a bit confusing to read this PR description. What exactly was dropped, just the list of AMI IDs in nixpkgs? |
This PR is closed, nothing was dropped. |
@RaitoBezarius Ah sorry, then I completely misunderstood. |
6 participants
Description of changes
This is a PR dropping all the Amazon stuff that is unmaintained in nixpkgs. Read commits for details.
Feel free to revert and add yourself as a maintainer if you care about a particular piece.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.