Skip to content

Comments

Add all available AWS regions#266354

Closed
johnalotoski wants to merge 1 commit intoNixOS:masterfrom
johnalotoski:update-aws-ami-regions
Closed

Add all available AWS regions#266354
johnalotoski wants to merge 1 commit intoNixOS:masterfrom
johnalotoski:update-aws-ami-regions

Conversation

@johnalotoski
Copy link

Description of changes

Adds new AWS regions since the last AMI update PR here.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Nov 8, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 9, 2023
@jopejoe1
Copy link
Member

jopejoe1 commented Nov 9, 2023

Pretty much the same as #263075

@johnalotoski
Copy link
Author

Pretty much the same as #263075

Lol, somehow how I missed seeing that existing one, thanks. It's exactly the same PR. Closing this PR.
Looking forward to the other PR getting merged and using those new region AMIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants