Skip to content

scripts/create-amis.sh: Update region list#272307

Merged
roberth merged 1 commit intoNixOS:masterfrom
hercules-ci:update-ec2-create-amis.sh
Dec 5, 2023
Merged

scripts/create-amis.sh: Update region list#272307
roberth merged 1 commit intoNixOS:masterfrom
hercules-ci:update-ec2-create-amis.sh

Conversation

@roberth
Copy link
Member

@roberth roberth commented Dec 5, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Dec 5, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 5, 2023
@arianvp
Copy link
Member

arianvp commented Dec 5, 2023

I'm currently reworking the upload ami script in https://GitHub.com/arianvp/amis and I will make sure all regions are automatically included there. I beg a bit of patience on that project.

I'm fine with merging this. But we might end up not using this script anymore for next release. Just a heads up.

Still useful change for people uploading their own AMIs though

@roberth roberth merged commit 6f8b4fb into NixOS:master Dec 5, 2023
@roberth
Copy link
Member Author

roberth commented Dec 5, 2023

Even better then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants