Added all current available AWS regions

[bolt12]

Description of changes

Added all currently available AWS regions to create-amis.sh file.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[roberth]

Seems like a good idea to sort.
Would be good to get this in soon, as it may be used at release time.

[roberth]

Suggested change

	# > aws ec2 describe-regions --all-regions --query "Regions[].{Name:RegionName}" --output text
	# > aws ec2 describe-regions --all-regions --query "Regions[].{Name:RegionName}" --output text | sort

I don't know what determines the current order, but we'll regret (slightly) not sorting if it changes.

[bolt12]

Great point!

[bolt12]

Addressed!

[roberth]

Please change the commit message to use imperative mood, as is standard in git. Some context is also helpful. Example

maintainers/create-amis.sh: Add all currently available AWS regions

Otherwise, lgtm!

[bolt12]

How about this @roberth ? Thank you very much for your review!

[roberth]

👍

[bolt12]

Ping @AmineChikhaoui

[AmineChikhaoui]

Hi, iirc the regions need to be enabled through the AWS account first. Since the diff isn't very clear, can you list what regions where added in this PR ?

[bolt12]

@AmineChikhaoui you'd have to enable all regions since this PR adds all regions currently available. There's also something else that might be needed to do which has to do with this warning on the Enable Regions dashboard:

AWS recommends using regional AWS Security Token Service (STS) endpoints to reduce latency. Session tokens from regional STS endpoints are valid in all AWS Regions. If you use regional STS endpoints, no action is required.

Session tokens from the global STS endpoint (https://sts.amazonaws.com) are valid only in AWS Regions that are enabled by default. If you intend to enable a new Region for your account, you can either use session tokens from regional STS endpoints or activate the global STS endpoint to issue session tokens that are valid in all AWS Regions. You can do this in Account Settings in the IAM console.

Session tokens that are valid in all AWS Regions are larger. If you store session tokens, these larger tokens might affect your systems. Learn more

So this might be need enabling as well