Skip to content

maintainers/teams: add ororatech#249520

Merged
tjni merged 3 commits intoNixOS:masterfrom
OroraTech:chore/add-maintainers
Aug 29, 2023
Merged

maintainers/teams: add ororatech#249520
tjni merged 3 commits intoNixOS:masterfrom
OroraTech:chore/add-maintainers

Conversation

@kip93
Copy link
Contributor

@kip93 kip93 commented Aug 16, 2023

Description of changes

Have a couple of PRs lined up which all require this team to be already set up, so I am making it its own PR.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@tjni tjni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@tjni tjni merged commit eb6ed91 into NixOS:master Aug 29, 2023
@kip93 kip93 deleted the chore/add-maintainers branch August 29, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants