Skip to content

python3Packages.dronecan: init at 1.0.25#249525

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
OroraTech:feature/add-dronecan
Sep 9, 2023
Merged

python3Packages.dronecan: init at 1.0.25#249525
Mic92 merged 1 commit intoNixOS:masterfrom
OroraTech:feature/add-dronecan

Conversation

@kip93
Copy link
Contributor

@kip93 kip93 commented Aug 16, 2023

Description of changes

Adds the dronecan python package.

Depends on #249520

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux (cross compiled from x86_64-linux)
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 16, 2023
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 16, 2023
@matthiasbeyer
Copy link
Contributor

Result of nixpkgs-review pr 249525 run on x86_64-linux 1

4 packages built:
  • python310Packages.dronecan
  • python310Packages.dronecan.dist
  • python311Packages.dronecan
  • python311Packages.dronecan.dist

@fabaff
Copy link
Member

fabaff commented Aug 23, 2023

Please squash the commits. For adding a new package it's preferred to not include all changes made during the review.

python311Packages.dronecan: init at 1.0.25

Using python311Packages. instead of python3Packages.will trigger the CI to build the package.

@kip93 kip93 force-pushed the feature/add-dronecan branch from 6ed36d1 to 3b19a5e Compare August 24, 2023 11:56
@kip93 kip93 force-pushed the feature/add-dronecan branch from 3b19a5e to fd1a11b Compare August 29, 2023 08:23
@Mic92 Mic92 merged commit c439cbc into NixOS:master Sep 9, 2023
@kip93 kip93 deleted the feature/add-dronecan branch September 30, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants