Skip to content

python311Packages.libpcap: init at 1.11.0b7#249532

Merged
Janik-Haag merged 1 commit intoNixOS:masterfrom
OroraTech:feature/add-libpcap
Sep 19, 2023
Merged

python311Packages.libpcap: init at 1.11.0b7#249532
Janik-Haag merged 1 commit intoNixOS:masterfrom
OroraTech:feature/add-libpcap

Conversation

@kip93
Copy link
Contributor

@kip93 kip93 commented Aug 16, 2023

Description of changes

Adds the libpcap python package.

Depends on #249520 & #249527

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux (cross compiled from x86_64-linux)
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 16, 2023
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 16, 2023
@matthiasbeyer
Copy link
Contributor

Result of nixpkgs-review pr 249532 run on x86_64-linux 1

8 packages built:
  • python310Packages.libpcap
  • python310Packages.libpcap.dist
  • python310Packages.pkg-about
  • python310Packages.pkg-about.dist
  • python311Packages.libpcap
  • python311Packages.libpcap.dist
  • python311Packages.pkg-about
  • python311Packages.pkg-about.dist

@kip93 kip93 force-pushed the feature/add-libpcap branch 2 times, most recently from 9fca037 to 4b9a956 Compare August 29, 2023 08:28
@matthiasbeyer
Copy link
Contributor

Result of nixpkgs-review pr 249532 run on x86_64-linux 1

8 packages failed to build:
  • python310Packages.libpcap
  • python310Packages.libpcap.dist
  • python310Packages.pkg-about
  • python310Packages.pkg-about.dist
  • python311Packages.libpcap
  • python311Packages.libpcap.dist
  • python311Packages.pkg-about
  • python311Packages.pkg-about.dist

@kip93 kip93 force-pushed the feature/add-libpcap branch 4 times, most recently from 9d19539 to cc35d16 Compare September 1, 2023 09:03
@Janik-Haag
Copy link
Member

Result of nixpkgs-review pr 249532 run on x86_64-linux 1

4 packages built:
  • python310Packages.libpcap
  • python310Packages.libpcap.dist
  • python311Packages.libpcap
  • python311Packages.libpcap.dist

Copy link
Member

@Janik-Haag Janik-Haag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kip93 kip93 requested review from Janik-Haag and wegank September 9, 2023 18:26
@wegank
Copy link
Member

wegank commented Sep 9, 2023

@ofborg build python311Packages.libpcap python311Packages.libpcap.passthru.tests

@wegank wegank marked this pull request as draft September 9, 2023 18:35
@kip93 kip93 force-pushed the feature/add-libpcap branch from 01280d4 to f453cea Compare September 9, 2023 18:49
@kip93 kip93 marked this pull request as ready for review September 9, 2023 18:50
@wegank wegank changed the title python3Packages.libpcap: init at 1.11.0b7 python311Packages.libpcap: init at 1.11.0b7 Sep 9, 2023
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 10, 2023
@Janik-Haag Janik-Haag requested a review from wegank September 12, 2023 20:09
@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Sep 18, 2023
@Janik-Haag Janik-Haag merged commit 9b3be3f into NixOS:master Sep 19, 2023
@kip93 kip93 deleted the feature/add-libpcap branch September 30, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments