python3Packages.pkg-about: init at 1.0.8#249527
Merged
fabaff merged 1 commit intoNixOS:masterfrom Sep 1, 2023
Merged
Conversation
github-actions
bot
added
the
6.topic: python
12 tasks
ofborg
bot
added
8.has: package (new)
Contributor
|
Result of 4 packages built:
|
fabaff
reviewed
Aug 16, 2023
fabaff
reviewed
Aug 23, 2023
kip93
force-pushed
the
feature/add-pkg-about
branch
3 times, most recently
from
cea4695 to
72dbf1b
Compare
Contributor
|
Result of 4 packages failed to build:
|
kip93
force-pushed
the
feature/add-pkg-about
branch
from
72dbf1b to
b0e9686
Compare
Member
|
Result of 4 packages built:
|
fabaff
approved these changes
Sep 1, 2023
Member
fabaff
left a comment
fabaff
left a comment
There was a problem hiding this comment.
Looks good to me.
Upstream should clean-up their requires as tox is most likely a test requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds the pkg-about python package.
Depends on #249520Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)