Add EIP-7910: Add eth_config #8956

flcl42 · 2025-07-08T06:08:53Z

Changes

Add eth_config

Types of changes

What types of changes does your code introduce?

Bugfix (a non-breaking change that fixes an issue)
New feature (a non-breaking change that adds functionality)
Breaking change (a change that causes existing functionality not to work as expected)
Optimization
Refactoring
Documentation update
Build-related changes
Other: Description

Testing

Requires testing

Yes
No

emlautarom1

Before approving we should add a couple of test cases, specifically related to serialization to ensure that the CRC-32 hashes are correct

src/Nethermind/Nethermind.Evm/Precompiles/IPrecompile.cs

src/Nethermind/Nethermind.JsonRpc/Modules/Eth/EthRpcModule.cs

src/Nethermind/Nethermind.JsonRpc/Data/EthConfigResult.cs

flcl42 · 2025-07-15T09:38:27Z

Before approving we should add a couple of test cases, specifically related to serialization to ensure that the CRC-32 hashes are correct

it will be provided by hive. I mean, it's hard to figure out what's expected and it will anyway repeat hive tests, so I'd wait for confirmation using the external tests

rubo · 2025-07-16T17:08:17Z

src/Nethermind/Nethermind.Evm.Precompiles/Snarks/Bn254MulPrecompile.cs


    public static Address Address { get; } = Address.FromNumber(7);

+    public static string Name => "BN256_MUL";


Why BN256?

Simply due to unknown reason. This name is taken from https://eips.ethereum.org/EIPS/eip-7910

So nothing will break if I change to BN254. It's a confusing mess everywhere with this naming.

It will break hash function and therefore the entire purpose of eth_config

(unless you change both https://eips.ethereum.org/EIPS/eip-7910 and our code)

Ah, this damn naming is coming from EIP. Missed that. So we check for Bn128... to add BN254... classes which return BN256... 😁 Damn

((we provide hashes of fork configs, so fields order, fields names should be fully the same, and no whitespace))

Yeah, as always naming is the hardest problem

(unless you change both https://eips.ethereum.org/EIPS/eip-7910 and our code)

I took it seriously: #9023 😄

* Update CLZ gas cost for devnet3 (#8953) * Update tx gas cap for devnet3 (#8954) * Don't block background tasks when syncing (#8971) * Don't block background tasks when syncing * fix test * fix compile warning * Concurrency 2 * Rename blob metrics (#8972) * Fix Taiko Engine Api (#8974) * Better null-ckecks in TryGetCanonicalTransaction (#8969) * Better null-ckecks in TryGetCanonicalTransaction * fix test * fix whitespace * fix test * Revise JSON-RPC docs generation (#8967) * Fix/OOM when downloading from genesis. (#8975) * Slight change in constructor * Stop putting more request when queue is high * Add unit test * Set budget as memory * Whitespace * Fix test * Cache PropertyInfo lookups for JsonRpc (#8976) * Auto-update fast sync settings (#8978) Co-authored-by: rubo <rubo@users.noreply.github.com> * Update OP Superchain chains (#8979) Co-authored-by: emlautarom1 <emlautarom1@users.noreply.github.com> * Remove use of Linq.Sum from hot paths (#8977) * Remove use of Linq.Sum from hot paths * Simplify * Isolate Tracer in Proof Module and remove IVisitingWorldState (#8981) * Scope the tracer * Use state reader in Tracer * Inline dump state * Remove accept * Delete IVisitingWorldState * Move dump state to state reader * Whitespace * More hot code in ConnectNodes (#8982) * Only access "warmup" hashtable once per warmup (#8983) * Only access "warm" up hashtable once per warmup * Update src/Nethermind/Nethermind.Evm/Instructions/EvmInstructions.cs Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> --------- Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> * EIP-7594: Constant maxBlobsPerTx (#8940) * Const maxBlobsPerTx * WS * Add tests(improve for the Gnosis case); add link * Fail fast on Db corruption (#8986) * Fail fast on Db corruption * Fix tests * Update src/Nethermind/Nethermind.Db.Rocks/DbOnTheRocks.cs Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com> --------- Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com> * Configure EWC Zurich hard fork (#8985) * feat: Add RegexOptions.Compiled flag to NewPayloadJsonRpcValidator (#8984) * Improve locking when looking up RlpDecoders (#8987) * Remove locking in RlpDecoder fast path * Feedback * Fix naming of data cost in ExecutePrecompile (#8994) fix naming of data cost * Move precompiles (#8962) * Move precompiles * Fix build * Fix formating * EthereumCodeInfoRepository * Remove EthereumPrecompiles class * Move precompiles into separate project * Fix build * Add EIP-7910: Add eth_config (#8956) * Add eth_config * Update systemContracts, refactor * Fix next/last hash to be null * Replace `eth_pairings` with `mcl` (#8992) * Unify BN254 naming (#9004) * Refactor/Move init DB to DI (#8997) * Wait to read channel before reading * Fix BN254 point deserialization (#9009) * Optimize ModExp (#9008) * Optimize ModExp * Faaster * Moar * work as nuint * use nint * cast via int * Remove unneeded casts * Move OldRuns to tests * fix benchmarks * Feedback * Less branches * Less branches * fixed invalid * Remove last orphan readonly tx processing scope. (#9005) * Fix workerloop * Replace read all with try read * Update config for tests * Update winget command (#9011) * Auto-update fast sync settings (#9013) Co-authored-by: rubo <rubo@users.noreply.github.com> * Update OP Superchain chains (#9014) Co-authored-by: emlautarom1 <emlautarom1@users.noreply.github.com> * Tidy up ecdsa overloads (#9015) * Tidy up ecdsa overloads * put back the increase * Tracing check to allow ilevm to be enabled for node and tests * Update verified * .. --------- Co-authored-by: Ben {chmark} Adams <thundercat@illyriad.co.uk> Co-authored-by: Alexey <me@flcl.me> Co-authored-by: Amirul Ashraf <asdacap@gmail.com> Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com> Co-authored-by: core-repository-dispatch-app[bot] <173070810+core-repository-dispatch-app[bot]@users.noreply.github.com> Co-authored-by: emlautarom1 <emlautarom1@users.noreply.github.com> Co-authored-by: Micke <155267459+reallesee@users.noreply.github.com> Co-authored-by: Marcin Sobczak <77129288+marcindsobczak@users.noreply.github.com> Co-authored-by: Nikita Mescheryakov <root@nikitam.io>

Add eth_config

eed729a

flcl42 force-pushed the add-eth-config branch from d3b7c9f to eed729a Compare July 8, 2025 06:11

Fix

30573ea

flcl42 force-pushed the add-eth-config branch from 95fe9b2 to 70867ce Compare July 8, 2025 16:20

Update systemContracts, refactor

e4eaa39

flcl42 force-pushed the add-eth-config branch from 70867ce to e4eaa39 Compare July 9, 2025 08:48

flcl42 mentioned this pull request Jul 8, 2025

Fusaka Devnet 3 changes #8949

Closed

21 tasks

Revert; add last

c185297

flcl42 force-pushed the add-eth-config branch from 0aaf0ac to c185297 Compare July 10, 2025 11:30

flcl42 added 4 commits July 14, 2025 12:44

Move names to precompiles

a74e002

Improve readability

26300d6

Merge master into add-eth-config

5542393

Fix ws

ef37bff

flcl42 marked this pull request as ready for review July 14, 2025 12:05

flcl42 requested review from Marchhill, asdacap, benaadams and emlautarom1 July 14, 2025 12:09

Fix build

5030f9c

flcl42 force-pushed the add-eth-config branch from b5d22bb to 5030f9c Compare July 14, 2025 12:36

flcl42 requested a review from ak88 July 14, 2025 14:03

Fix compilation

beed31a

flcl42 force-pushed the add-eth-config branch from ebb525c to beed31a Compare July 14, 2025 14:45

emlautarom1 requested changes Jul 14, 2025

View reviewed changes

src/Nethermind/Nethermind.Evm/Precompiles/IPrecompile.cs Show resolved Hide resolved

src/Nethermind/Nethermind.JsonRpc/Modules/Eth/EthRpcModule.cs Outdated Show resolved Hide resolved

src/Nethermind/Nethermind.JsonRpc/Data/EthConfigResult.cs Outdated Show resolved Hide resolved

flcl42 added 2 commits July 14, 2025 21:20

Fix dict; genesis time; options

75b4315

Fix test

46d7117

ak88 approved these changes Jul 15, 2025

View reviewed changes

emlautarom1 approved these changes Jul 15, 2025

View reviewed changes

Fix next/last hash to be null

c4020a6

Merge master into add-eth-config

19a10b6

flcl42 force-pushed the add-eth-config branch from bc759fa to 19a10b6 Compare July 16, 2025 16:17

flcl42 merged commit 4540a7f into master Jul 16, 2025
77 checks passed

flcl42 deleted the add-eth-config branch July 16, 2025 16:32

rubo reviewed Jul 16, 2025

View reviewed changes

benaadams added the new feature label Aug 4, 2025


		public static Address Address { get; } = Address.FromNumber(7);

		public static string Name => "BN256_MUL";

Add EIP-7910: Add eth_config #8956

Add EIP-7910: Add eth_config #8956

Uh oh!

Conversation

flcl42 commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Types of changes

What types of changes does your code introduce?

Testing

Requires testing

Uh oh!

emlautarom1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

flcl42 commented Jul 15, 2025

Uh oh!

Uh oh!

rubo Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

flcl42 Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

rubo Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

flcl42 Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

flcl42 Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

rubo Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

flcl42 Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flcl42 Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

rubo Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

flcl42 commented Jul 8, 2025 •

edited

Loading

flcl42 Jul 16, 2025 •

edited

Loading

rubo Jul 21, 2025 •

edited

Loading