Refactor/Move init DB to DI #8997

asdacap · 2025-07-17T03:23:26Z

Move db initialization to DI.
Remove StandardDbInitializer.
Some DbProvider registration. DbProvider is now just a proxy to the container.
Full pruning db is implement by overriding state db's IDb. No need for special code elsewhere.

Types of changes

What types of changes does your code introduce?

Refactoring

Testing

Requires testing

Yes
No

If yes, did you write tests?

Yes
No

Notes on testing

Existing mainnet db run normally.
Mainnet sync normally

benaadams · 2025-07-18T02:24:35Z

src/Nethermind/Nethermind.Db/DbTracker.cs

+
+    public void AddDb(string name, IDbMeta dbMeta)
+    {
+        _createdDbs.TryAdd(name, dbMeta);


Can this mean the db gets lost; as you add but fail because it already exists; however return one passed in?

Should it be GetOrAdd?

Does the one not added need to be disposed?

If we have duplicated name then we have a bigger problem.

Disposal is handled by the container automatically.

Should we do something if adding fail? Dispose? throw error? log error at least?

Copilot

Pull Request Overview

This PR refactors database initialization by moving it into a dependency injection (DI) container. The main changes include removing the StandardDbInitializer class, converting DbProvider to use the DI container as a proxy, and implementing full pruning database functionality through override of state db's IDb rather than special code elsewhere.

Move database initialization from StandardDbInitializer to a new DbModule in DI
Replace DbProvider with a container-proxy implementation
Implement full pruning database through state db override in WorldStateModule

Reviewed Changes

Copilot reviewed 59 out of 59 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
Nethermind.Init/Modules/DbModule.cs	New module that handles database initialization and registration in DI container
Nethermind.Db/DbProvider.cs	Simplified to act as proxy to DI container instead of managing databases directly
Nethermind.Db/StandardDbInitializer.cs	Removed - functionality moved to DbModule
Nethermind.Init/Modules/WorldStateModule.cs	Added special state db configuration with full pruning support
Nethermind.JsonRpc.TraceStore/TraceStorePlugin.cs	Updated to use new DI-based database registration

src/Nethermind/Nethermind.Init/Modules/DbModule.cs

src/Nethermind/Nethermind.Init/Modules/ContainerBuilderExtensions.cs

src/Nethermind/Nethermind.JsonRpc.TraceStore/TraceStorePruner.cs

Copilot · 2025-07-18T02:25:53Z

src/Nethermind/Nethermind.Init/Steps/InitDatabase.cs

 namespace Nethermind.Init.Steps
 {
    [RunnerStepDependencies(typeof(ApplyMemoryHint))]
+    [Todo("Remove. Need to move `InitDatabaseSnapshot` to its own step also")]


[nitpick] The TODO comment indicates this class should be removed but provides incomplete guidance. Consider adding more specific details about the migration plan or timeline for removal.

Suggested change

[Todo("Remove. Need to move `InitDatabaseSnapshot` to its own step also")]

[Todo("Remove. Plan: Move `InitDatabaseSnapshot` to its own step. Ensure all references to `InitDatabase` are updated to use the new step. Timeline: Complete by Q4 2023.")]

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ons.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update CLZ gas cost for devnet3 (#8953) * Update tx gas cap for devnet3 (#8954) * Don't block background tasks when syncing (#8971) * Don't block background tasks when syncing * fix test * fix compile warning * Concurrency 2 * Rename blob metrics (#8972) * Fix Taiko Engine Api (#8974) * Better null-ckecks in TryGetCanonicalTransaction (#8969) * Better null-ckecks in TryGetCanonicalTransaction * fix test * fix whitespace * fix test * Revise JSON-RPC docs generation (#8967) * Fix/OOM when downloading from genesis. (#8975) * Slight change in constructor * Stop putting more request when queue is high * Add unit test * Set budget as memory * Whitespace * Fix test * Cache PropertyInfo lookups for JsonRpc (#8976) * Auto-update fast sync settings (#8978) Co-authored-by: rubo <rubo@users.noreply.github.com> * Update OP Superchain chains (#8979) Co-authored-by: emlautarom1 <emlautarom1@users.noreply.github.com> * Remove use of Linq.Sum from hot paths (#8977) * Remove use of Linq.Sum from hot paths * Simplify * Isolate Tracer in Proof Module and remove IVisitingWorldState (#8981) * Scope the tracer * Use state reader in Tracer * Inline dump state * Remove accept * Delete IVisitingWorldState * Move dump state to state reader * Whitespace * More hot code in ConnectNodes (#8982) * Only access "warmup" hashtable once per warmup (#8983) * Only access "warm" up hashtable once per warmup * Update src/Nethermind/Nethermind.Evm/Instructions/EvmInstructions.cs Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> --------- Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> * EIP-7594: Constant maxBlobsPerTx (#8940) * Const maxBlobsPerTx * WS * Add tests(improve for the Gnosis case); add link * Fail fast on Db corruption (#8986) * Fail fast on Db corruption * Fix tests * Update src/Nethermind/Nethermind.Db.Rocks/DbOnTheRocks.cs Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com> --------- Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com> * Configure EWC Zurich hard fork (#8985) * feat: Add RegexOptions.Compiled flag to NewPayloadJsonRpcValidator (#8984) * Improve locking when looking up RlpDecoders (#8987) * Remove locking in RlpDecoder fast path * Feedback * Fix naming of data cost in ExecutePrecompile (#8994) fix naming of data cost * Move precompiles (#8962) * Move precompiles * Fix build * Fix formating * EthereumCodeInfoRepository * Remove EthereumPrecompiles class * Move precompiles into separate project * Fix build * Add EIP-7910: Add eth_config (#8956) * Add eth_config * Update systemContracts, refactor * Fix next/last hash to be null * Replace `eth_pairings` with `mcl` (#8992) * Unify BN254 naming (#9004) * Refactor/Move init DB to DI (#8997) * Wait to read channel before reading * Fix BN254 point deserialization (#9009) * Optimize ModExp (#9008) * Optimize ModExp * Faaster * Moar * work as nuint * use nint * cast via int * Remove unneeded casts * Move OldRuns to tests * fix benchmarks * Feedback * Less branches * Less branches * fixed invalid * Remove last orphan readonly tx processing scope. (#9005) * Fix workerloop * Replace read all with try read * Update config for tests * Update winget command (#9011) * Auto-update fast sync settings (#9013) Co-authored-by: rubo <rubo@users.noreply.github.com> * Update OP Superchain chains (#9014) Co-authored-by: emlautarom1 <emlautarom1@users.noreply.github.com> * Tidy up ecdsa overloads (#9015) * Tidy up ecdsa overloads * put back the increase * Tracing check to allow ilevm to be enabled for node and tests * Update verified * .. --------- Co-authored-by: Ben {chmark} Adams <thundercat@illyriad.co.uk> Co-authored-by: Alexey <me@flcl.me> Co-authored-by: Amirul Ashraf <asdacap@gmail.com> Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com> Co-authored-by: core-repository-dispatch-app[bot] <173070810+core-repository-dispatch-app[bot]@users.noreply.github.com> Co-authored-by: emlautarom1 <emlautarom1@users.noreply.github.com> Co-authored-by: Micke <155267459+reallesee@users.noreply.github.com> Co-authored-by: Marcin Sobczak <77129288+marcindsobczak@users.noreply.github.com> Co-authored-by: Nikita Mescheryakov <root@nikitam.io>

asdacap added 11 commits July 17, 2025 11:24

Move init db to DI

bef30d9

Remove unused code

94d544c

Remove unused code

ee57055

Rename back

1f390a5

Change namespace

39b6312

Comment and cleanup

5a97b99

Test keyed mapper

ea8b84e

Db tracker test

138252f

Smaller

c96236e

Slight cleanup

e9301f2

Slight comment

a00c0ca

asdacap force-pushed the refactor/move-init-db-to-di branch from 77fa2f9 to a00c0ca Compare July 17, 2025 03:25

asdacap mentioned this pull request Jul 17, 2025

Feature/adjust rocksdb config by memory #9000

Merged

9 tasks

benaadams reviewed Jul 18, 2025

View reviewed changes

benaadams requested a review from Copilot July 18, 2025 02:24

Copilot AI reviewed Jul 18, 2025

View reviewed changes

benaadams approved these changes Jul 18, 2025

View reviewed changes

asdacap and others added 4 commits July 18, 2025 11:16

Update src/Nethermind/Nethermind.Init/Modules/DbModule.cs

3157410

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/Nethermind/Nethermind.Init/Modules/DbModule.cs

8e87b2c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/Nethermind/Nethermind.JsonRpc.TraceStore/TraceStorePruner.cs

98ab26b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/Nethermind/Nethermind.Init/Modules/ContainerBuilderExtensi…

8bee6a1

…ons.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

asdacap merged commit 763442d into master Jul 18, 2025
77 checks passed

asdacap deleted the refactor/move-init-db-to-di branch July 18, 2025 06:06

benaadams added the refactoring label Aug 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor/Move init DB to DI #8997

Refactor/Move init DB to DI #8997

Uh oh!

asdacap commented Jul 17, 2025

Uh oh!

benaadams Jul 18, 2025

Uh oh!

asdacap Jul 18, 2025

Uh oh!

LukaszRozmej Jul 18, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jul 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	[Todo("Remove. Need to move `InitDatabaseSnapshot` to its own step also")]
	[Todo("Remove. Plan: Move `InitDatabaseSnapshot` to its own step. Ensure all references to `InitDatabase` are updated to use the new step. Timeline: Complete by Q4 2023.")]

Refactor/Move init DB to DI #8997

Refactor/Move init DB to DI #8997

Uh oh!

Conversation

asdacap commented Jul 17, 2025

Types of changes

What types of changes does your code introduce?

Testing

Requires testing

If yes, did you write tests?

Notes on testing

Uh oh!

benaadams Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

asdacap Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

LukaszRozmej Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants