Skip to content

Fix Taiko Engine Api #8974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asdacap merged 2 commits into from
Jul 11, 2025
Merged

Fix Taiko Engine Api #8974

asdacap merged 2 commits into from
Jul 11, 2025

Conversation

@asdacap
Copy link
Contributor

@asdacap asdacap commented Jul 11, 2025

  • The auto collection resolver have a weird ordering behaviour with nested module causing the default engine api to be used instead of taiko's engine api as its registration appear later than taiko's.
  • This PR add some explicit DSL to ensure ordering.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Logged the registered module order.

dipkakwani
dipkakwani approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@dipkakwani dipkakwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the Taiko issue! 😄

src/Nethermind/Nethermind.Core/Container/OrderedComponents.cs
private IList<T> _components = new List<T>();
public IEnumerable<T> Components => _components;

public void AddLast(T item)
Copy link
Member

@dipkakwani dipkakwani Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, this API isn't enforcing which will be the last element? In case of two consecutive AddLast calls, the first call becomes effectively invalid and it may get overridden. Would it make sense to somehow enforce calling these functions only once?

Copy link
Contributor Author

@asdacap asdacap Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ow, I did not expect that use case.

Copy link
Contributor Author

@asdacap asdacap Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that can make sense for other use case, but in this case, there are other rpc module also. We just need taiko to run after merge.

@asdacap asdacap merged commit 2ae971c into master Jul 11, 2025
135 of 137 checks passed
@asdacap asdacap deleted the feature/iordered-components branch July 11, 2025 08:27
Demuirgos pushed a commit that referenced this pull request Jul 16, 2025
@SiddharthV1 @benaadams
@flcl42 @asdacap @LukaszRozmej @rubo @core-repository-dispatch-app @emlautarom1
Fixes to ilevm (ethereum tests) (#8988)
e6b9ff8 
* Update CLZ gas cost for devnet3 (#8953)

* Update tx gas cap for devnet3 (#8954)

* Don't block background tasks when syncing (#8971)

* Don't block background tasks when syncing

* fix test

* fix compile warning

* Concurrency 2

* Rename blob metrics (#8972)

* Fix Taiko Engine Api (#8974)

* Fix call opcode

* Better null-ckecks in TryGetCanonicalTransaction (#8969)

* Better null-ckecks in TryGetCanonicalTransaction

* fix test

* fix whitespace

* fix test

* Revise JSON-RPC docs generation (#8967)

* Fix/OOM when downloading from genesis. (#8975)

* Slight change in constructor

* Stop putting more request when queue is high

* Add unit test

* Set budget as memory

* Whitespace

* Fix test

* Cache PropertyInfo lookups for JsonRpc (#8976)

* Auto-update fast sync settings (#8978)

Co-authored-by: rubo <rubo@users.noreply.github.com>

* Update OP Superchain chains (#8979)

Co-authored-by: emlautarom1 <emlautarom1@users.noreply.github.com>

* Remove use of Linq.Sum from hot paths (#8977)

* Remove use of Linq.Sum from hot paths

* Simplify

* Fix sstore

* Notice execution only if code length  > 0

* Isolate Tracer in Proof Module and remove IVisitingWorldState (#8981)

* Scope the tracer

* Use state reader in Tracer

* Inline dump state

* Remove accept

* Delete IVisitingWorldState

* Move dump state to state reader

* Whitespace

* More hot code in ConnectNodes (#8982)

* Only access "warmup" hashtable once per warmup (#8983)

* Only access "warm" up hashtable once per warmup

* Update src/Nethermind/Nethermind.Evm/Instructions/EvmInstructions.cs

Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>

---------

Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>

* EIP-7594: Constant maxBlobsPerTx  (#8940)

* Const maxBlobsPerTx

* WS

* Add tests(improve for the Gnosis case); add link

* Fail fast on Db corruption (#8986)

* Fail fast on Db corruption

* Fix tests

* Update src/Nethermind/Nethermind.Db.Rocks/DbOnTheRocks.cs

Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>

---------

Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>

* Fix extcodecopy & extcodehash

* Formatting

---------

Co-authored-by: Ben {chmark} Adams <thundercat@illyriad.co.uk>
Co-authored-by: Alexey <me@flcl.me>
Co-authored-by: Amirul Ashraf <asdacap@gmail.com>
Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>
Co-authored-by: core-repository-dispatch-app[bot] <173070810+core-repository-dispatch-app[bot]@users.noreply.github.com>
Co-authored-by: emlautarom1 <emlautarom1@users.noreply.github.com>
Demuirgos pushed a commit that referenced this pull request Jul 17, 2025
@SiddharthV1 @benaadams
@flcl42 @asdacap @LukaszRozmej @rubo @core-repository-dispatch-app @emlautarom1 @reallesee
Fix tracing check to enable ilevm execution & minor test fixes (#8996)
30af72d 
* Update CLZ gas cost for devnet3 (#8953)

* Update tx gas cap for devnet3 (#8954)

* Don't block background tasks when syncing (#8971)

* Don't block background tasks when syncing

* fix test

* fix compile warning

* Concurrency 2

* Rename blob metrics (#8972)

* Fix Taiko Engine Api (#8974)

* Fix call opcode

* Better null-ckecks in TryGetCanonicalTransaction (#8969)

* Better null-ckecks in TryGetCanonicalTransaction

* fix test

* fix whitespace

* fix test

* Revise JSON-RPC docs generation (#8967)

* Fix/OOM when downloading from genesis. (#8975)

* Slight change in constructor

* Stop putting more request when queue is high

* Add unit test

* Set budget as memory

* Whitespace

* Fix test

* Cache PropertyInfo lookups for JsonRpc (#8976)

* Auto-update fast sync settings (#8978)

Co-authored-by: rubo <rubo@users.noreply.github.com>

* Update OP Superchain chains (#8979)

Co-authored-by: emlautarom1 <emlautarom1@users.noreply.github.com>

* Remove use of Linq.Sum from hot paths (#8977)

* Remove use of Linq.Sum from hot paths

* Simplify

* Fix sstore

* Notice execution only if code length  > 0

* Isolate Tracer in Proof Module and remove IVisitingWorldState (#8981)

* Scope the tracer

* Use state reader in Tracer

* Inline dump state

* Remove accept

* Delete IVisitingWorldState

* Move dump state to state reader

* Whitespace

* More hot code in ConnectNodes (#8982)

* Only access "warmup" hashtable once per warmup (#8983)

* Only access "warm" up hashtable once per warmup

* Update src/Nethermind/Nethermind.Evm/Instructions/EvmInstructions.cs

Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>

---------

Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>

* EIP-7594: Constant maxBlobsPerTx  (#8940)

* Const maxBlobsPerTx

* WS

* Add tests(improve for the Gnosis case); add link

* Fail fast on Db corruption (#8986)

* Fail fast on Db corruption

* Fix tests

* Update src/Nethermind/Nethermind.Db.Rocks/DbOnTheRocks.cs

Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>

---------

Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>

* Fix extcodecopy & extcodehash

* Formatting

* Configure EWC Zurich hard fork (#8985)

* feat: Add RegexOptions.Compiled flag to NewPayloadJsonRpcValidator (#8984)

* Check for null code hash

* Improve locking when looking up RlpDecoders (#8987)

* Remove locking in RlpDecoder fast path

* Feedback

* Opt in no_ilevm mode in tests

* Fix ilevm executes only when not tracing

* Fix ilevm tracing check

* Fix tracing check that allows ilevm analysis & execution

* Formatting

* Fix spelling

---------

Co-authored-by: Ben {chmark} Adams <thundercat@illyriad.co.uk>
Co-authored-by: Alexey <me@flcl.me>
Co-authored-by: Amirul Ashraf <asdacap@gmail.com>
Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>
Co-authored-by: core-repository-dispatch-app[bot] <173070810+core-repository-dispatch-app[bot]@users.noreply.github.com>
Co-authored-by: emlautarom1 <emlautarom1@users.noreply.github.com>
Co-authored-by: Micke <155267459+reallesee@users.noreply.github.com>
Demuirgos pushed a commit that referenced this pull request Jul 21, 2025
@SiddharthV1 @benaadams
@flcl42 @asdacap @LukaszRozmej @rubo @core-repository-dispatch-app @emlautarom1 @reallesee @marcindsobczak @deffrian
Fix worker loop (#9007)
6083e36 
* Update CLZ gas cost for devnet3 (#8953)

* Update tx gas cap for devnet3 (#8954)

* Don't block background tasks when syncing (#8971)

* Don't block background tasks when syncing

* fix test

* fix compile warning

* Concurrency 2

* Rename blob metrics (#8972)

* Fix Taiko Engine Api (#8974)

* Better null-ckecks in TryGetCanonicalTransaction (#8969)

* Better null-ckecks in TryGetCanonicalTransaction

* fix test

* fix whitespace

* fix test

* Revise JSON-RPC docs generation (#8967)

* Fix/OOM when downloading from genesis. (#8975)

* Slight change in constructor

* Stop putting more request when queue is high

* Add unit test

* Set budget as memory

* Whitespace

* Fix test

* Cache PropertyInfo lookups for JsonRpc (#8976)

* Auto-update fast sync settings (#8978)

Co-authored-by: rubo <rubo@users.noreply.github.com>

* Update OP Superchain chains (#8979)

Co-authored-by: emlautarom1 <emlautarom1@users.noreply.github.com>

* Remove use of Linq.Sum from hot paths (#8977)

* Remove use of Linq.Sum from hot paths

* Simplify

* Isolate Tracer in Proof Module and remove IVisitingWorldState (#8981)

* Scope the tracer

* Use state reader in Tracer

* Inline dump state

* Remove accept

* Delete IVisitingWorldState

* Move dump state to state reader

* Whitespace

* More hot code in ConnectNodes (#8982)

* Only access "warmup" hashtable once per warmup (#8983)

* Only access "warm" up hashtable once per warmup

* Update src/Nethermind/Nethermind.Evm/Instructions/EvmInstructions.cs

Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>

---------

Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>

* EIP-7594: Constant maxBlobsPerTx  (#8940)

* Const maxBlobsPerTx

* WS

* Add tests(improve for the Gnosis case); add link

* Fail fast on Db corruption (#8986)

* Fail fast on Db corruption

* Fix tests

* Update src/Nethermind/Nethermind.Db.Rocks/DbOnTheRocks.cs

Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>

---------

Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>

* Configure EWC Zurich hard fork (#8985)

* feat: Add RegexOptions.Compiled flag to NewPayloadJsonRpcValidator (#8984)

* Improve locking when looking up RlpDecoders (#8987)

* Remove locking in RlpDecoder fast path

* Feedback

* Fix naming of data cost in ExecutePrecompile (#8994)

fix naming of data cost

* Move precompiles (#8962)

* Move precompiles

* Fix build

* Fix formating

* EthereumCodeInfoRepository

* Remove EthereumPrecompiles class

* Move precompiles into separate project

* Fix build

* Add EIP-7910: Add eth_config (#8956)

* Add eth_config
* Update systemContracts, refactor
* Fix next/last hash to be null

* Replace `eth_pairings` with `mcl` (#8992)

* Unify BN254 naming (#9004)

* Refactor/Move init DB to DI (#8997)

* Wait to read channel before reading

* Fix BN254 point deserialization (#9009)

* Optimize ModExp (#9008)

* Optimize ModExp

* Faaster

* Moar

* work as nuint

* use nint

* cast via int

* Remove unneeded casts

* Move OldRuns to tests

* fix benchmarks

* Feedback

* Less branches

* Less branches

* fixed invalid

* Remove last orphan readonly tx processing scope. (#9005)

* Fix workerloop

* Replace read all with try read

* Update config for tests

* Update winget command (#9011)

* Auto-update fast sync settings (#9013)

Co-authored-by: rubo <rubo@users.noreply.github.com>

* Update OP Superchain chains (#9014)

Co-authored-by: emlautarom1 <emlautarom1@users.noreply.github.com>

* Tidy up ecdsa overloads (#9015)

* Tidy up ecdsa overloads

* put back the increase

* Tracing check to allow ilevm to be enabled for node and tests

* Update verified

* ..

---------

Co-authored-by: Ben {chmark} Adams <thundercat@illyriad.co.uk>
Co-authored-by: Alexey <me@flcl.me>
Co-authored-by: Amirul Ashraf <asdacap@gmail.com>
Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>
Co-authored-by: core-repository-dispatch-app[bot] <173070810+core-repository-dispatch-app[bot]@users.noreply.github.com>
Co-authored-by: emlautarom1 <emlautarom1@users.noreply.github.com>
Co-authored-by: Micke <155267459+reallesee@users.noreply.github.com>
Co-authored-by: Marcin Sobczak <77129288+marcindsobczak@users.noreply.github.com>
Co-authored-by: Nikita Mescheryakov <root@nikitam.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dipkakwani dipkakwani dipkakwani approved these changes

Assignees

No one assigned

Labels

bug fix + reliability new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asdacap @dipkakwani @benaadams