Move precompiles #8962

deffrian · 2025-07-08T17:49:52Z

Fixes Closes Resolves #
This pr is part of zk evm project

Changes

Now precompiles are part of Nethermind.Blockchain
Using CodeInfoRepository we can replace default precompiles with custom implementations
Some metrics are also moved

Types of changes

What types of changes does your code introduce?

Bugfix (a non-breaking change that fixes an issue)
New feature (a non-breaking change that adds functionality)
Breaking change (a change that causes existing functionality not to work as expected)
Optimization
Refactoring
Documentation update
Build-related changes
Other: Description

Testing

Requires testing

Yes
No

Documentation

Requires documentation update

Yes
No

Requires explanation in Release Notes

Yes
No

LukaszRozmej

Doesn't really belong in Blockchain, would prefer creating Evm.Precompiles project.

LukaszRozmej · 2025-07-16T08:47:11Z

src/Nethermind/Nethermind.Evm/Instructions/EvmInstructions.cs

 using Int256;

-internal static unsafe partial class EvmInstructions
+public static unsafe partial class EvmInstructions


Move stuff to Nethermind.Evm.Precompiles. Keep this internal but add InternalsVisibleTo attribute.

LukaszRozmej · 2025-07-16T08:49:53Z

src/Nethermind/Nethermind.Evm/Instructions/EvmInstructions.cs


            // If the account is cold (and not a precompile), charge the cold access cost.
-            if (!address.IsPrecompile(spec) && vmState.AccessTracker.WarmUp(address))
+            if (!vm.CodeInfoRepository.IsPrecompile(address, spec) && vmState.AccessTracker.WarmUp(address))


I think CodeInfoRepository could be made internal here instead of public in vm

My plan is that evm users will be able to do something like
MyCustomCodeInfoRepository : CodeInfoRepository(myPrecompiles)

flcl42 · 2025-07-16T09:29:57Z

src/Nethermind/Nethermind.Blockchain/EthereumCodeInfoRepository.cs

+    {
+        get => new Dictionary<AddressAsKey, PrecompileInfo>
+        {
+            [EcRecoverPrecompile.Address] = new PrecompileInfo(EcRecoverPrecompile.Instance),


Can be just new() instead of new PrecompileInfo

LukaszRozmej · 2025-07-16T13:57:31Z

src/Nethermind/Nethermind.Blockchain/EthereumCodeInfoRepository.cs

+
+namespace Nethermind.Blockchain;
+
+public class EthereumCodeInfoRepository(


I wonder if this one and Cached should also be moved to Evm.Precompiles, but don't have strong opinion on it.
Leaning on yes, Cached is caching precompiles, this is adding precompiles.

* Update CLZ gas cost for devnet3 (#8953) * Update tx gas cap for devnet3 (#8954) * Don't block background tasks when syncing (#8971) * Don't block background tasks when syncing * fix test * fix compile warning * Concurrency 2 * Rename blob metrics (#8972) * Fix Taiko Engine Api (#8974) * Better null-ckecks in TryGetCanonicalTransaction (#8969) * Better null-ckecks in TryGetCanonicalTransaction * fix test * fix whitespace * fix test * Revise JSON-RPC docs generation (#8967) * Fix/OOM when downloading from genesis. (#8975) * Slight change in constructor * Stop putting more request when queue is high * Add unit test * Set budget as memory * Whitespace * Fix test * Cache PropertyInfo lookups for JsonRpc (#8976) * Auto-update fast sync settings (#8978) Co-authored-by: rubo <rubo@users.noreply.github.com> * Update OP Superchain chains (#8979) Co-authored-by: emlautarom1 <emlautarom1@users.noreply.github.com> * Remove use of Linq.Sum from hot paths (#8977) * Remove use of Linq.Sum from hot paths * Simplify * Isolate Tracer in Proof Module and remove IVisitingWorldState (#8981) * Scope the tracer * Use state reader in Tracer * Inline dump state * Remove accept * Delete IVisitingWorldState * Move dump state to state reader * Whitespace * More hot code in ConnectNodes (#8982) * Only access "warmup" hashtable once per warmup (#8983) * Only access "warm" up hashtable once per warmup * Update src/Nethermind/Nethermind.Evm/Instructions/EvmInstructions.cs Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> --------- Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> * EIP-7594: Constant maxBlobsPerTx (#8940) * Const maxBlobsPerTx * WS * Add tests(improve for the Gnosis case); add link * Fail fast on Db corruption (#8986) * Fail fast on Db corruption * Fix tests * Update src/Nethermind/Nethermind.Db.Rocks/DbOnTheRocks.cs Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com> --------- Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com> * Configure EWC Zurich hard fork (#8985) * feat: Add RegexOptions.Compiled flag to NewPayloadJsonRpcValidator (#8984) * Improve locking when looking up RlpDecoders (#8987) * Remove locking in RlpDecoder fast path * Feedback * Fix naming of data cost in ExecutePrecompile (#8994) fix naming of data cost * Move precompiles (#8962) * Move precompiles * Fix build * Fix formating * EthereumCodeInfoRepository * Remove EthereumPrecompiles class * Move precompiles into separate project * Fix build * Add EIP-7910: Add eth_config (#8956) * Add eth_config * Update systemContracts, refactor * Fix next/last hash to be null * Replace `eth_pairings` with `mcl` (#8992) * Unify BN254 naming (#9004) * Refactor/Move init DB to DI (#8997) * Wait to read channel before reading * Fix BN254 point deserialization (#9009) * Optimize ModExp (#9008) * Optimize ModExp * Faaster * Moar * work as nuint * use nint * cast via int * Remove unneeded casts * Move OldRuns to tests * fix benchmarks * Feedback * Less branches * Less branches * fixed invalid * Remove last orphan readonly tx processing scope. (#9005) * Fix workerloop * Replace read all with try read * Update config for tests * Update winget command (#9011) * Auto-update fast sync settings (#9013) Co-authored-by: rubo <rubo@users.noreply.github.com> * Update OP Superchain chains (#9014) Co-authored-by: emlautarom1 <emlautarom1@users.noreply.github.com> * Tidy up ecdsa overloads (#9015) * Tidy up ecdsa overloads * put back the increase * Tracing check to allow ilevm to be enabled for node and tests * Update verified * .. --------- Co-authored-by: Ben {chmark} Adams <thundercat@illyriad.co.uk> Co-authored-by: Alexey <me@flcl.me> Co-authored-by: Amirul Ashraf <asdacap@gmail.com> Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com> Co-authored-by: core-repository-dispatch-app[bot] <173070810+core-repository-dispatch-app[bot]@users.noreply.github.com> Co-authored-by: emlautarom1 <emlautarom1@users.noreply.github.com> Co-authored-by: Micke <155267459+reallesee@users.noreply.github.com> Co-authored-by: Marcin Sobczak <77129288+marcindsobczak@users.noreply.github.com> Co-authored-by: Nikita Mescheryakov <root@nikitam.io>

deffrian added 4 commits July 8, 2025 20:49

Move precompiles

e219daf

Fix build

48ffb74

Fix formating

f5614af

EthereumCodeInfoRepository

951cc5b

deffrian changed the title ~~[WIP]Move precompiles~~ Move precompiles Jul 9, 2025

deffrian marked this pull request as ready for review July 9, 2025 15:36

deffrian added 2 commits July 9, 2025 19:16

Remove EthereumPrecompiles class

543e153

Merge branch 'master' into refactor/evm-remove-precompiles

b3d5ac4

tanishqjasoria requested a review from LukaszRozmej July 16, 2025 06:35

tanishqjasoria approved these changes Jul 16, 2025

View reviewed changes

LukaszRozmej requested review from Demuirgos and benaadams July 16, 2025 08:38

LukaszRozmej reviewed Jul 16, 2025

View reviewed changes

flcl42 reviewed Jul 16, 2025

View reviewed changes

deffrian added 2 commits July 16, 2025 14:52

Move precompiles into separate project

9b44ca4

Fix build

611a16e

LukaszRozmej approved these changes Jul 16, 2025

View reviewed changes

deffrian merged commit b9f48a5 into master Jul 16, 2025
77 checks passed

deffrian deleted the refactor/evm-remove-precompiles branch July 16, 2025 14:22

benaadams added the refactoring label Aug 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move precompiles #8962

Move precompiles #8962

Uh oh!

deffrian commented Jul 8, 2025 •

edited

Loading

Uh oh!

LukaszRozmej left a comment

Uh oh!

LukaszRozmej Jul 16, 2025

Uh oh!

LukaszRozmej Jul 16, 2025 •

edited

Loading

Uh oh!

deffrian Jul 16, 2025

Uh oh!

flcl42 Jul 16, 2025

Uh oh!

LukaszRozmej Jul 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants


		namespace Nethermind.Blockchain;

		public class EthereumCodeInfoRepository(

Move precompiles #8962

Move precompiles #8962

Uh oh!

Conversation

deffrian commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Types of changes

What types of changes does your code introduce?

Testing

Requires testing

Documentation

Requires documentation update

Requires explanation in Release Notes

Uh oh!

LukaszRozmej left a comment

Choose a reason for hiding this comment

Uh oh!

LukaszRozmej Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

LukaszRozmej Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

deffrian Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

flcl42 Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

LukaszRozmej Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

deffrian commented Jul 8, 2025 •

edited

Loading

LukaszRozmej Jul 16, 2025 •

edited

Loading

LukaszRozmej Jul 16, 2025 •

edited

Loading