Skip to content

Revise BN254 precompile names #9023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rubo merged 1 commit into from
Jul 21, 2025
Merged

Revise BN254 precompile names #9023

rubo merged 1 commit into from
Jul 21, 2025

Conversation

@rubo
Copy link
Contributor

@rubo rubo commented Jul 21, 2025

Changes

Updated BN254 precompiles' names as per EIP-7910 update. See context.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

@rubo rubo requested a review from flcl42 July 21, 2025 16:10
@rubo rubo mentioned this pull request Jul 21, 2025
Merged
10 tasks
@rubo rubo requested review from ak88 and emlautarom1 July 21, 2025 16:14
@rubo rubo marked this pull request as ready for review July 21, 2025 16:16
@flcl42
Copy link
Contributor

flcl42 commented Jul 21, 2025 •
edited
Loading

You need to fix the EIP, because hashes are different too now. ( "currentHash": "0x243c27d1 -> ...", etc)

@rubo
Copy link
Contributor Author

rubo commented Jul 21, 2025

You need to fix the EIP, because hashes are different too now. ( "currentHash": "0x243c27d1 -> ...", etc)

ethereum/EIPs#10039

@flcl42
Copy link
Contributor

flcl42 commented Jul 21, 2025

And next and last probably

@rubo
Copy link
Contributor Author

rubo commented Jul 21, 2025

Everything is up to date in the EIP.

@rubo rubo merged commit 9359283 into master Jul 21, 2025
78 checks passed
@rubo rubo deleted the fix/eip-7910-update branch July 21, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flcl42 flcl42 flcl42 approved these changes

@ak88 ak88 Awaiting requested review from ak88

@emlautarom1 emlautarom1 Awaiting requested review from emlautarom1

Assignees

No one assigned

Labels

new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rubo @flcl42 @benaadams