fix(ci): fix configuration for breaking change notification workflow - #2151
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR hardens the breaking-change alert workflow by restricting default GitHub token permissions and updating the Slack notification secret configuration. The ChangesWorkflow Security Hardening
🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
| - labeled | ||
| - unlabeled | ||
|
|
||
| permissions: {} |
There was a problem hiding this comment.
Looks like some other repos (like RMM and cuDF) don't have this. Should we add this throughout?
There was a problem hiding this comment.
(repeating what I said offline for the history here)
Only rmm and cudf specifically were missing this. I've added it in both.
|
/merge |
…VIDIA#2151) Contributes to rapidsai/shared-workflows#560 Fixes misconfigurations in the GitHub Actions workflow that generates Notifications when PRs are labeled `breaking`. Any other changes come from making the configuration for this workflow identical across all RAPIDS repos. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - https://github.com/jakirkham URL: NVIDIA#2151
Contributes to rapidsai/shared-workflows#560
Fixes misconfigurations in the GitHub Actions workflow that generates Notifications when PRs are labeled
breaking.Any other changes come from making the configuration for this workflow identical across all RAPIDS repos.