Skip to content

fix(ci): fix configuration for breaking change notification workflow - #22732

Merged
rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
jameslamb:fix/breaking-change-alert
Jun 2, 2026
Merged

fix(ci): fix configuration for breaking change notification workflow#22732
rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
jameslamb:fix/breaking-change-alert

Conversation

@jameslamb

Copy link
Copy Markdown
Member

Contributes to rapidsai/shared-workflows#560

Fixes misconfigurations in the GitHub Actions workflow that generates Notifications when PRs are labeled breaking.

Any other changes come from making the configuration for this workflow identical across all RAPIDS repos.

@jameslamb jameslamb added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jun 1, 2026
@copy-pr-bot

copy-pr-bot Bot commented Jun 1, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb

Copy link
Copy Markdown
Member Author

/ok to test 0446455

@jameslamb
jameslamb marked this pull request as ready for review June 1, 2026 16:26
@jameslamb
jameslamb requested a review from a team as a code owner June 1, 2026 16:26
@jameslamb
jameslamb requested a review from gforsyth June 1, 2026 16:26
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c997d479-4358-459b-affe-762ca8fc672f

📥 Commits

Reviewing files that changed from the base of the PR and between 0446455 and 38b13a9.

📒 Files selected for processing (1)
  • .github/workflows/trigger-breaking-change-alert.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/trigger-breaking-change-alert.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated breaking-change notification workflow configuration for proper alert routing.
    • Clarified inline documentation explaining safe trigger usage.
    • Adjusted workflow input to ensure notifications are sent to the correct notifier.

Walkthrough

Updates .github/workflows/trigger-breaking-change-alert.yaml: changes the reusable workflow input slack-webhook-url to use secrets.NV_SLACK_BREAKING_CHANGE_NOTIFIER_APP and adds comments documenting that the PR trigger usage is safe because it does not run PR-specific code.

Changes

Breaking-change alert workflow update

Layer / File(s) Summary
Slack webhook secret migration and safety documentation
.github/workflows/trigger-breaking-change-alert.yaml
Workflow input slack-webhook-url is remapped from ${{ secrets.NV_SLACK_BREAKING_CHANGE_ALERT }} to ${{ secrets.NV_SLACK_BREAKING_CHANGE_NOTIFIER_APP }}. Inline comments state that the pull_request_target trigger usage is safe and does not execute PR-specific code.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes


Suggested reviewers

  • msarahan
  • jakirkham
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing CI configuration for breaking change notification workflow, which matches the core alteration to the slack-webhook-url secret reference.
Description check ✅ Passed The description is directly related to the changeset, explaining that it fixes misconfigurations in the GitHub Actions workflow for breaking change notifications and aligns configuration across RAPIDS repos.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@jakirkham jakirkham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks James! 🙏

Comment thread .github/workflows/trigger-breaking-change-alert.yaml
Co-authored-by: jakirkham <jakirkham@gmail.com>
@jameslamb

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit 48b0ac2 into NVIDIA:main Jun 2, 2026
73 checks passed
@jameslamb
jameslamb deleted the fix/breaking-change-alert branch June 2, 2026 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants