Skip to content

Use main shared-workflows branch - #2259

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
bdice:cuda-13.3.0-use-main
Jun 24, 2026
Merged

Use main shared-workflows branch#2259
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
bdice:cuda-13.3.0-use-main

Conversation

@bdice

@bdice bdice commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Contributes to rapidsai/build-planning#286

Notes for Reviewers

This reverts GitHub Actions workflow references from the CUDA 13.3.0 shared-workflows branch back to main.

@bdice
bdice requested a review from a team as a code owner June 24, 2026 04:28
@bdice
bdice requested a review from gforsyth June 24, 2026 04:28
@bdice bdice added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jun 24, 2026
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflow configurations across build, test, and deployment pipelines to use the latest shared workflow versions.

Walkthrough

All uses: references to rapidsai/shared-workflows reusable workflows across .github/workflows/build.yaml, pr.yaml, test.yaml, and trigger-breaking-change-alert.yaml are changed from the pinned @cuda-13.3.0 tag to the moving @main branch. No other workflow logic is modified.

Changes

Shared-workflow ref bump across all CI workflows

Layer / File(s) Summary
build.yaml: all uses refs → @main
.github/workflows/build.yaml
All 17 uses: lines (conda-cpp-build, compute-matrix, custom-job, conda-python-build, conda-upload-packages, wheels-build, wheels-publish, build-devcontainers) are updated from @cuda-13.3.0 to @main.
pr.yaml: all uses refs → @main
.github/workflows/pr.yaml
All 23 uses: lines across pr-builder, changed-files, checks, conda C++/Python chain, rocky8, Java, Rust, Go, docs, wheel-build, wheels-test, and devcontainer jobs are updated from @cuda-13.3.0 to @main.
test.yaml and trigger alert: all uses refs → @main
.github/workflows/test.yaml, .github/workflows/trigger-breaking-change-alert.yaml
Five uses: lines in test.yaml (conda-cpp-post-build-checks, conda-cpp-tests, conda-python-tests, custom-job, wheels-test) and one in trigger-breaking-change-alert.yaml (breaking-change-alert) are updated from @cuda-13.3.0 to @main.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • rapidsai/cuvs#2151: Also modifies the trigger-notifier job in trigger-breaking-change-alert.yaml that reuses the shared breaking-change-alert workflow, updating its token permissions and Slack secret mapping.

Suggested reviewers

  • jameslamb
  • jakirkham
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and directly describes the main change: updating shared-workflows references to use the main branch instead of a pinned version.
Description check ✅ Passed The description accurately relates to the changeset by explaining the reversion from CUDA 13.3.0 shared-workflows to main and references the relevant issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/build.yaml:
- Line 46: The workflow reference on line 46 (and other referenced lines with
`@main`) uses a mutable branch reference instead of an immutable commit SHA,
which creates non-reproducible builds and security risks. Replace all instances
of `@main` at the end of shared workflow references (specifically prioritizing
lines 46, 71, 105, 138, 171, 196, 239, 257, 298 which have high privilege
delegation with `id-token: write` and `secrets: inherit`) with a specific
40-character commit SHA to ensure reproducibility and reduce supply-chain risk.
Obtain the appropriate immutable SHA from the shared-workflows repository and
update each reference accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0ef69775-cc32-4604-8126-dcd083d7c399

📥 Commits

Reviewing files that changed from the base of the PR and between 71306ec and d05e543.

📒 Files selected for processing (4)
  • .github/workflows/build.yaml
  • .github/workflows/pr.yaml
  • .github/workflows/test.yaml
  • .github/workflows/trigger-breaking-change-alert.yaml

Comment thread .github/workflows/build.yaml
@gforsyth gforsyth added non-breaking Introduces a non-breaking change and removed non-breaking Introduces a non-breaking change labels Jun 24, 2026
@gforsyth

Copy link
Copy Markdown
Contributor

/merge

@rapids-bot
rapids-bot Bot merged commit 1cf252a into NVIDIA:main Jun 24, 2026
168 of 170 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants