Skip to content

add default permissions block in trigger-breaking-change-alert config - #2438

Merged
rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
jameslamb:more-breaking-change-config
Jun 1, 2026
Merged

add default permissions block in trigger-breaking-change-alert config#2438
rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
jameslamb:more-breaking-change-config

Conversation

@jameslamb

Copy link
Copy Markdown
Member

Description

Follow-up to #2435

Adds a default permissions: {} block in the trigger-breaking-change-alert GitHub Actions configuration. This change reduces the risk of unnecessary permissions being granted to that workflow, and standardizes with all other RAPIDS repos (rapidsai/shared-workflows#560).

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb
jameslamb requested a review from jakirkham June 1, 2026 22:20
@jameslamb
jameslamb requested a review from a team as a code owner June 1, 2026 22:20
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 000bc078-9da8-44ae-9545-80a3bbb3b525

📥 Commits

Reviewing files that changed from the base of the PR and between 6215ecd and ac6e3d5.

📒 Files selected for processing (1)
  • .github/workflows/trigger-breaking-change-alert.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflow configuration to enhance security settings for pull request handling.

Walkthrough

This PR adds a workflow-level empty permissions: {} configuration to the trigger-breaking-change-alert.yaml workflow file. This restricts the GitHub token's default permissions, applying a security hardening practice to the pull request target trigger.

Changes

Workflow Permissions Configuration

Layer / File(s) Summary
Empty permissions restriction for pull_request_target
.github/workflows/trigger-breaking-change-alert.yaml
The workflow now declares an empty permissions: {} block at the top level, restricting GitHub token permissions for the pull_request_target trigger.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • rapidsai/rmm#2435: Both PRs modify the same workflow file and apply related permission configuration changes for the breaking-change alert job.

Suggested labels

non-breaking, improvement

Suggested reviewers

  • jakirkham
  • KyleFromNVIDIA
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding a default permissions block to the trigger-breaking-change-alert workflow configuration.
Description check ✅ Passed The description is clearly related to the changeset, providing context about the purpose of adding permissions block, referencing a follow-up issue, and explaining standardization with other repositories.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@jakirkham jakirkham added bug Something isn't working non-breaking Non-breaking change labels Jun 1, 2026
@jakirkham

Copy link
Copy Markdown
Member

Thanks James! 🙏

@bdice

bdice commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

/merge

@rapids-bot
rapids-bot Bot merged commit 4d354f6 into rapidsai:main Jun 1, 2026
87 checks passed
@jameslamb
jameslamb deleted the more-breaking-change-config branch June 2, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants