Skip to content

fix(ci): fix configuration for breaking change notification workflow #2151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 1 commit into from
Jun 2, 2026
Merged

fix(ci): fix configuration for breaking change notification workflow #2151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/trigger-breaking-change-alert.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,16 @@ on: # zizmor: ignore[dangerous-triggers]
- labeled
- unlabeled

permissions: {}

@jakirkham jakirkham Jun 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some other repos (like RMM and cuDF) don't have this. Should we add this throughout?

@jameslamb jameslamb Jun 2, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(repeating what I said offline for the history here)

Only rmm and cudf specifically were missing this. I've added it in both.


jobs:
trigger-notifier:
if: contains(github.event.pull_request.labels.*.name, 'breaking')
permissions:
contents: read
uses: rapidsai/shared-workflows/.github/workflows/breaking-change-alert.yaml@main
secrets:
NV_SLACK_BREAKING_CHANGE_ALERT: ${{ secrets.NV_SLACK_BREAKING_CHANGE_ALERT }}
slack-webhook-url: ${{ secrets.NV_SLACK_BREAKING_CHANGE_NOTIFIER_APP }}
with:
sender_login: ${{ github.event.sender.login }}
sender_avatar: ${{ github.event.sender.avatar_url }}
Expand Down
Loading